From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jdelvare@suse.de, netdev@vger.kernel.org, jslaby@suse.cz
Subject: Re: [PATCH] net: pch_gbe depends on x86_32
Date: Fri, 16 May 2014 13:05:58 -0400 (EDT) [thread overview]
Message-ID: <20140516.130558.261976058112825591.davem@davemloft.net> (raw)
In-Reply-To: <1400246161.7973.162.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 16 May 2014 06:16:01 -0700
> On Fri, 2014-05-16 at 11:29 +0200, Jean Delvare wrote:
>> The pch_gbe driver is for a companion chip to the Intel Atom E600
>> series processors. These are 32-bit x86 processors so the driver is
>> only needed on X86_32.
>>
>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
>> Cc: Jiri Slaby <jslaby@suse.cz>
>> Cc: David S. Miller <davem@davemloft.net>
>> ---
>> drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-03-31 05:40:15.000000000 +0200
>> +++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-05-16 11:20:28.453261606 +0200
>> @@ -4,7 +4,7 @@
>>
>> config PCH_GBE
>> tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
>> - depends on PCI && (X86 || COMPILE_TEST)
>> + depends on PCI && (X86_32 || COMPILE_TEST)
>> select MII
>> select PTP_1588_CLOCK_PCH
>> ---help---
>>
>>
>
> Although its always nice to be able to compile it with x86_64 host,
> to make sure we do not add regressions when we change something in a
> core networking part.
That's what COMPILE_TEST is supposed to be for and it's still there :)
next prev parent reply other threads:[~2014-05-16 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 9:29 [PATCH] net: pch_gbe depends on x86_32 Jean Delvare
2014-05-16 13:16 ` Eric Dumazet
2014-05-16 17:05 ` David Miller [this message]
2014-05-16 17:26 ` Eric Dumazet
2014-05-16 21:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516.130558.261976058112825591.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jdelvare@suse.de \
--cc=jslaby@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).