* [PATCH] net: pch_gbe depends on x86_32
@ 2014-05-16 9:29 Jean Delvare
2014-05-16 13:16 ` Eric Dumazet
2014-05-16 21:01 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Jean Delvare @ 2014-05-16 9:29 UTC (permalink / raw)
To: netdev; +Cc: Jiri Slaby, David S. Miller
The pch_gbe driver is for a companion chip to the Intel Atom E600
series processors. These are 32-bit x86 processors so the driver is
only needed on X86_32.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: David S. Miller <davem@davemloft.net>
---
drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-03-31 05:40:15.000000000 +0200
+++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-05-16 11:20:28.453261606 +0200
@@ -4,7 +4,7 @@
config PCH_GBE
tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
- depends on PCI && (X86 || COMPILE_TEST)
+ depends on PCI && (X86_32 || COMPILE_TEST)
select MII
select PTP_1588_CLOCK_PCH
---help---
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: pch_gbe depends on x86_32
2014-05-16 9:29 [PATCH] net: pch_gbe depends on x86_32 Jean Delvare
@ 2014-05-16 13:16 ` Eric Dumazet
2014-05-16 17:05 ` David Miller
2014-05-16 21:01 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2014-05-16 13:16 UTC (permalink / raw)
To: Jean Delvare; +Cc: netdev, Jiri Slaby, David S. Miller
On Fri, 2014-05-16 at 11:29 +0200, Jean Delvare wrote:
> The pch_gbe driver is for a companion chip to the Intel Atom E600
> series processors. These are 32-bit x86 processors so the driver is
> only needed on X86_32.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: David S. Miller <davem@davemloft.net>
> ---
> drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-03-31 05:40:15.000000000 +0200
> +++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-05-16 11:20:28.453261606 +0200
> @@ -4,7 +4,7 @@
>
> config PCH_GBE
> tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
> - depends on PCI && (X86 || COMPILE_TEST)
> + depends on PCI && (X86_32 || COMPILE_TEST)
> select MII
> select PTP_1588_CLOCK_PCH
> ---help---
>
>
Although its always nice to be able to compile it with x86_64 host,
to make sure we do not add regressions when we change something in a
core networking part.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: pch_gbe depends on x86_32
2014-05-16 13:16 ` Eric Dumazet
@ 2014-05-16 17:05 ` David Miller
2014-05-16 17:26 ` Eric Dumazet
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-05-16 17:05 UTC (permalink / raw)
To: eric.dumazet; +Cc: jdelvare, netdev, jslaby
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 16 May 2014 06:16:01 -0700
> On Fri, 2014-05-16 at 11:29 +0200, Jean Delvare wrote:
>> The pch_gbe driver is for a companion chip to the Intel Atom E600
>> series processors. These are 32-bit x86 processors so the driver is
>> only needed on X86_32.
>>
>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
>> Cc: Jiri Slaby <jslaby@suse.cz>
>> Cc: David S. Miller <davem@davemloft.net>
>> ---
>> drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-03-31 05:40:15.000000000 +0200
>> +++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-05-16 11:20:28.453261606 +0200
>> @@ -4,7 +4,7 @@
>>
>> config PCH_GBE
>> tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
>> - depends on PCI && (X86 || COMPILE_TEST)
>> + depends on PCI && (X86_32 || COMPILE_TEST)
>> select MII
>> select PTP_1588_CLOCK_PCH
>> ---help---
>>
>>
>
> Although its always nice to be able to compile it with x86_64 host,
> to make sure we do not add regressions when we change something in a
> core networking part.
That's what COMPILE_TEST is supposed to be for and it's still there :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: pch_gbe depends on x86_32
2014-05-16 17:05 ` David Miller
@ 2014-05-16 17:26 ` Eric Dumazet
0 siblings, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2014-05-16 17:26 UTC (permalink / raw)
To: David Miller; +Cc: jdelvare, netdev, jslaby
On Fri, 2014-05-16 at 13:05 -0400, David Miller wrote:
> That's what COMPILE_TEST is supposed to be for and it's still there :)
Ah nice, I missed this feature, thanks ;)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: pch_gbe depends on x86_32
2014-05-16 9:29 [PATCH] net: pch_gbe depends on x86_32 Jean Delvare
2014-05-16 13:16 ` Eric Dumazet
@ 2014-05-16 21:01 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2014-05-16 21:01 UTC (permalink / raw)
To: jdelvare; +Cc: netdev, jslaby
From: Jean Delvare <jdelvare@suse.de>
Date: Fri, 16 May 2014 11:29:04 +0200
> The pch_gbe driver is for a companion chip to the Intel Atom E600
> series processors. These are 32-bit x86 processors so the driver is
> only needed on X86_32.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-16 21:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-16 9:29 [PATCH] net: pch_gbe depends on x86_32 Jean Delvare
2014-05-16 13:16 ` Eric Dumazet
2014-05-16 17:05 ` David Miller
2014-05-16 17:26 ` Eric Dumazet
2014-05-16 21:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).