From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: pch_gbe depends on x86_32 Date: Fri, 16 May 2014 13:05:58 -0400 (EDT) Message-ID: <20140516.130558.261976058112825591.davem@davemloft.net> References: <20140516112904.7072da0f@endymion.delvare> <1400246161.7973.162.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jdelvare@suse.de, netdev@vger.kernel.org, jslaby@suse.cz To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:47050 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbaEPRGD (ORCPT ); Fri, 16 May 2014 13:06:03 -0400 In-Reply-To: <1400246161.7973.162.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Fri, 16 May 2014 06:16:01 -0700 > On Fri, 2014-05-16 at 11:29 +0200, Jean Delvare wrote: >> The pch_gbe driver is for a companion chip to the Intel Atom E600 >> series processors. These are 32-bit x86 processors so the driver is >> only needed on X86_32. >> >> Signed-off-by: Jean Delvare >> Cc: Jiri Slaby >> Cc: David S. Miller >> --- >> drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-03-31 05:40:15.000000000 +0200 >> +++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-05-16 11:20:28.453261606 +0200 >> @@ -4,7 +4,7 @@ >> >> config PCH_GBE >> tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE" >> - depends on PCI && (X86 || COMPILE_TEST) >> + depends on PCI && (X86_32 || COMPILE_TEST) >> select MII >> select PTP_1588_CLOCK_PCH >> ---help--- >> >> > > Although its always nice to be able to compile it with x86_64 host, > to make sure we do not add regressions when we change something in a > core networking part. That's what COMPILE_TEST is supposed to be for and it's still there :)