netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Alexei Starovoitov' <alexei.starovoitov@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] pktgen: Use seq_puts() where seq_printf() is not needed
Date: Fri, 16 May 2014 16:23:46 +0100	[thread overview]
Message-ID: <20140516152346.GF8346@casper.infradead.org> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1724771A@AcuExch.aculab.com>

On 05/16/14 at 03:08pm, David Laight wrote:
> From: Alexei Starovoitov
> > > -       seq_printf(seq, "dst_mac: ");
> > > +       seq_puts(seq, "dst_mac: ");
> > 
> > tough luck of kernel developers... ;)
> > Normal printf() GCC optimizes into puts() automatically.
> 
> Yes - a PITA when you are compiling for an embedded system
> with a very limited 'libc'.
> 
> Unless I was actually worried about the execution time I'd
> leave them as seq_printf() for consistency through the function.

pktgen already used seq_puts() in various places but not
consistently. Now it does. Besides that, checkpatch.pl specifically
complained about the use of seq_printf() on non format strings.

  reply	other threads:[~2014-05-16 15:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16 10:53 [PATCH net-next] pktgen: Use seq_puts() where seq_printf() is not needed Thomas Graf
2014-05-16 15:02 ` Alexei Starovoitov
2014-05-16 15:08   ` David Laight
2014-05-16 15:23     ` Thomas Graf [this message]
2014-05-16 21:02 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140516152346.GF8346@casper.infradead.org \
    --to=tgraf@suug.ch \
    --cc=David.Laight@ACULAB.COM \
    --cc=alexei.starovoitov@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).