From: Timo Teras <timo.teras@iki.fi>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] net: gro: make sure skb->cb[] initial content has not to be zero
Date: Fri, 16 May 2014 22:08:22 +0300 [thread overview]
Message-ID: <20140516220822.5d749752@vostro> (raw)
In-Reply-To: <1400265277.5367.13.camel@edumazet-glaptop2.roam.corp.google.com>
On Fri, 16 May 2014 11:34:37 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Starting from linux-3.13, GRO attempts to build full size skbs.
>
> Problem is the commit assumed one particular field in skb->cb[]
> was clean, but it is not the case on some stacked devices.
>
> Timo reported a crash in case traffic is decrypted before
> reaching a GRE device.
>
> Fix this by initializing NAPI_GRO_CB(skb)->last at the right place,
> this also removes one conditional.
>
> Thanks a lot to Timo for providing full reports and bisecting this.
>
> Fixes: 8a29111c7ca6 ("net: gro: allow to build full sized skb")
> Bisected-by: Timo Teras <timo.teras@iki.fi>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> Please Timo test this patch so that we confirm it fixes the bug for
> you.
Yes, everything looks green now! (The test case reproduced the crash
reliably and immediately. Now it's been up and working for more than
tens minutes already :)
Tested-by: Timo Teräs <timo.teras@iki.fi>
Needless to say, this should go to 3.14-stable as well.
Thanks a lot Eric!
next prev parent reply other threads:[~2014-05-16 19:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 7:40 [bisected] [oops] gre/gro oops in skb_gro_receive+0x118/0x453 Timo Teras
2014-05-16 12:59 ` Eric Dumazet
2014-05-16 14:34 ` Timo Teras
2014-05-16 16:29 ` Eric Dumazet
2014-05-16 16:40 ` Timo Teras
2014-05-16 16:50 ` Eric Dumazet
2014-05-16 17:01 ` Timo Teras
2014-05-16 17:13 ` Eric Dumazet
2014-05-16 17:38 ` Timo Teras
2014-05-16 18:04 ` Eric Dumazet
2014-05-16 18:34 ` [PATCH] net: gro: make sure skb->cb[] initial content has not to be zero Eric Dumazet
2014-05-16 19:08 ` Timo Teras [this message]
2014-05-16 21:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516220822.5d749752@vostro \
--to=timo.teras@iki.fi \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).