From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: ariele@broadcom.com, dmitry@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2x: Convert return 0 to return rc
Date: Sun, 18 May 2014 20:51:35 -0400 (EDT) [thread overview]
Message-ID: <20140518.205135.2035618521487962929.davem@davemloft.net> (raw)
In-Reply-To: <1400223103.30884.5.camel@joe-AO725>
From: Joe Perches <joe@perches.com>
Date: Thu, 15 May 2014 23:51:43 -0700
> These "return 0;" uses seem wrong as there are
> rc variables where error return values are set
> but unused.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
prev parent reply other threads:[~2014-05-19 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 6:51 [PATCH] bnx2x: Convert return 0 to return rc Joe Perches
2014-05-16 12:02 ` Dmitry Kravkov
2014-05-16 20:12 ` Joe Perches
2014-05-16 20:49 ` David Miller
2014-05-19 0:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140518.205135.2035618521487962929.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=dmitry@broadcom.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).