From: David Miller <davem@davemloft.net>
To: rickard_strandqvist@spectrumdigital.se
Cc: isdn@linux-pingi.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isdn: hisax: l3ni1.c: Fix for possible null pointer dereference
Date: Sun, 18 May 2014 21:13:19 -0400 (EDT) [thread overview]
Message-ID: <20140518.211319.776876380782689458.davem@davemloft.net> (raw)
In-Reply-To: <1400347180-25553-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Date: Sat, 17 May 2014 19:19:40 +0200
> @@ -2064,8 +2064,12 @@ static int l3ni1_cmd_global(struct PStack *st, isdn_ctrl *ic)
> { free_invoke_id(st, id);
> return (-2);
> }
> - pc->prot.ni1.ll_id = ic->parm.ni1_io.ll_id; /* remember id */
> - pc->prot.ni1.proc = ic->parm.ni1_io.proc; /* and procedure */
> +
> + if (pc)
> + {
> + pc->prot.ni1.ll_id = ic->parm.ni1_io.ll_id; /* remember id */
> + pc->prot.ni1.proc = ic->parm.ni1_io.proc; /* and procedure */
> + }
Like I said for your other patch, you should fix this by putting these
assignments in the timeout > 0 code block.
next prev parent reply other threads:[~2014-05-19 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 17:19 [PATCH] isdn: hisax: l3ni1.c: Fix for possible null pointer dereference Rickard Strandqvist
2014-05-19 1:13 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-06 12:04 Rickard Strandqvist
2014-07-08 23:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140518.211319.776876380782689458.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).