From: David Miller <davem@davemloft.net>
To: cengelma@gmx.at
Cc: netdev@vger.kernel.org, amirv@mellanox.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels()
Date: Sun, 18 May 2014 21:14:57 -0400 (EDT) [thread overview]
Message-ID: <20140518.211457.1577062584301411622.davem@davemloft.net> (raw)
In-Reply-To: <1400363523-18371-1-git-send-email-cengelma@gmx.at>
From: Christian Engelmayer <cengelma@gmx.at>
Date: Sat, 17 May 2014 23:52:03 +0200
> Function mlx4_en_set_channels() stops running ports before performing the
> requested action. In that case local variable 'port_up' is set so that the
> port is restarted at the end of the function, however, in case the port was
> not stopped, variable 'port_up' is left uninitialized and the behaviour is
> undetermined. Detected by Coverity - CID 751497.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Applied, thanks.
prev parent reply other threads:[~2014-05-19 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 21:52 [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels() Christian Engelmayer
2014-05-18 11:43 ` Amir Vadai
2014-05-19 1:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140518.211457.1577062584301411622.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=cengelma@gmx.at \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).