* [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels()
@ 2014-05-17 21:52 Christian Engelmayer
2014-05-18 11:43 ` Amir Vadai
2014-05-19 1:14 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Christian Engelmayer @ 2014-05-17 21:52 UTC (permalink / raw)
To: netdev; +Cc: amirv, linux-kernel, Christian Engelmayer
Function mlx4_en_set_channels() stops running ports before performing the
requested action. In that case local variable 'port_up' is set so that the
port is restarted at the end of the function, however, in case the port was
not stopped, variable 'port_up' is left uninitialized and the behaviour is
undetermined. Detected by Coverity - CID 751497.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
Compile tested. Applies against branch master in tree
git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
---
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
index a72d99f..7ba3df3 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
@@ -1121,7 +1121,7 @@ static int mlx4_en_set_channels(struct net_device *dev,
{
struct mlx4_en_priv *priv = netdev_priv(dev);
struct mlx4_en_dev *mdev = priv->mdev;
- int port_up;
+ int port_up = 0;
int err = 0;
if (channel->other_count || channel->combined_count ||
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels()
2014-05-17 21:52 [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels() Christian Engelmayer
@ 2014-05-18 11:43 ` Amir Vadai
2014-05-19 1:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Amir Vadai @ 2014-05-18 11:43 UTC (permalink / raw)
To: Christian Engelmayer, netdev; +Cc: linux-kernel
On 5/18/2014 12:52 AM, Christian Engelmayer wrote:
> Function mlx4_en_set_channels() stops running ports before performing the
> requested action. In that case local variable 'port_up' is set so that the
> port is restarted at the end of the function, however, in case the port was
> not stopped, variable 'port_up' is left uninitialized and the behaviour is
> undetermined. Detected by Coverity - CID 751497.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
Acked-By: Amir Vadai <amirv@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels()
2014-05-17 21:52 [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels() Christian Engelmayer
2014-05-18 11:43 ` Amir Vadai
@ 2014-05-19 1:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-05-19 1:14 UTC (permalink / raw)
To: cengelma; +Cc: netdev, amirv, linux-kernel
From: Christian Engelmayer <cengelma@gmx.at>
Date: Sat, 17 May 2014 23:52:03 +0200
> Function mlx4_en_set_channels() stops running ports before performing the
> requested action. In that case local variable 'port_up' is set so that the
> port is restarted at the end of the function, however, in case the port was
> not stopped, variable 'port_up' is left uninitialized and the behaviour is
> undetermined. Detected by Coverity - CID 751497.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-19 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-17 21:52 [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels() Christian Engelmayer
2014-05-18 11:43 ` Amir Vadai
2014-05-19 1:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).