* [PATCH net] ip_tunnel: Initialize the fallback device properly
@ 2014-05-15 7:43 Steffen Klassert
2014-05-15 13:22 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Steffen Klassert @ 2014-05-15 7:43 UTC (permalink / raw)
To: David Miller; +Cc: netdev
We need to initialize the fallback device to have a correct mtu
set on this device. Otherwise the mtu is set to null and the device
is unusable.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
net/ipv4/ip_tunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index b3f8597..25b8997 100644
--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -882,6 +882,7 @@ int ip_tunnel_init_net(struct net *net, int ip_tnl_net_id,
*/
if (!IS_ERR(itn->fb_tunnel_dev)) {
itn->fb_tunnel_dev->features |= NETIF_F_NETNS_LOCAL;
+ itn->fb_tunnel_dev->mtu = ip_tunnel_bind_dev(itn->fb_tunnel_dev);
ip_tunnel_add(itn, netdev_priv(itn->fb_tunnel_dev));
}
rtnl_unlock();
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] ip_tunnel: Initialize the fallback device properly
2014-05-15 7:43 [PATCH net] ip_tunnel: Initialize the fallback device properly Steffen Klassert
@ 2014-05-15 13:22 ` Eric Dumazet
2014-05-19 9:34 ` Steffen Klassert
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2014-05-15 13:22 UTC (permalink / raw)
To: Steffen Klassert; +Cc: David Miller, netdev
On Thu, 2014-05-15 at 09:43 +0200, Steffen Klassert wrote:
> We need to initialize the fallback device to have a correct mtu
> set on this device. Otherwise the mtu is set to null and the device
> is unusable.
>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
> ---
> net/ipv4/ip_tunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
> index b3f8597..25b8997 100644
> --- a/net/ipv4/ip_tunnel.c
> +++ b/net/ipv4/ip_tunnel.c
> @@ -882,6 +882,7 @@ int ip_tunnel_init_net(struct net *net, int ip_tnl_net_id,
> */
> if (!IS_ERR(itn->fb_tunnel_dev)) {
> itn->fb_tunnel_dev->features |= NETIF_F_NETNS_LOCAL;
> + itn->fb_tunnel_dev->mtu = ip_tunnel_bind_dev(itn->fb_tunnel_dev);
> ip_tunnel_add(itn, netdev_priv(itn->fb_tunnel_dev));
> }
> rtnl_unlock();
Hi Steffen.
It would be nice if you also added the reference of the commit
adding the bug ;)
Thanks !
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-19 9:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-15 7:43 [PATCH net] ip_tunnel: Initialize the fallback device properly Steffen Klassert
2014-05-15 13:22 ` Eric Dumazet
2014-05-19 9:34 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).