From: David Miller <davem@davemloft.net>
To: bjorn@mork.no
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
alexey.orishko@gmail.com, oliver@neukum.org, mrkiko.rs@gmail.com,
David.Laight@ACULAB.COM, sfr@canb.auug.org.au
Subject: Re: [PATCH net-next] net: cdc_ncm: fix 64bit division build error
Date: Wed, 21 May 2014 01:56:56 -0400 (EDT) [thread overview]
Message-ID: <20140521.015656.1427912008346226331.davem@davemloft.net> (raw)
In-Reply-To: <1400484069-13702-1-git-send-email-bjorn@mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Mon, 19 May 2014 09:21:09 +0200
> The upper timer_interval limit is arbitrary and much higher
> than anything usable in the real world. Reducing it from 15s
> to ~4s to make the timer_interval fit in an u32 does not make
> much difference. The limit is still outside the practical
> bounds.
>
> This eliminates the need for a 64bit timer_interval, fixing a
> build error related to 64bit division:
>
> drivers/built-in.o: In function `cdc_ncm_get_coalesce':
> ak8975.c:(.text+0x1ac994): undefined reference to `__aeabi_uldivmod'
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Applied, thank you.
prev parent reply other threads:[~2014-05-21 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 7:21 [PATCH net-next] net: cdc_ncm: fix 64bit division build error Bjørn Mork
2014-05-21 2:07 ` Stephen Rothwell
2014-05-21 5:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521.015656.1427912008346226331.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=alexey.orishko@gmail.com \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).