* [PATCH net v2] ip_tunnel: Initialize the fallback device properly
@ 2014-05-19 9:36 Steffen Klassert
2014-05-21 6:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Steffen Klassert @ 2014-05-19 9:36 UTC (permalink / raw)
To: David Miller; +Cc: Eric Dumazet, Pravin B Shelar, netdev
We need to initialize the fallback device to have a correct mtu
set on this device. Otherwise the mtu is set to null and the device
is unusable.
Fixes: fd58156e456d ("IPIP: Use ip-tunneling code.")
Cc: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
v2: Add a reference to the commit that added the bug.
No code changes since v1.
net/ipv4/ip_tunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index 49721d7..2acc233 100644
--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -883,6 +883,7 @@ int ip_tunnel_init_net(struct net *net, int ip_tnl_net_id,
*/
if (!IS_ERR(itn->fb_tunnel_dev)) {
itn->fb_tunnel_dev->features |= NETIF_F_NETNS_LOCAL;
+ itn->fb_tunnel_dev->mtu = ip_tunnel_bind_dev(itn->fb_tunnel_dev);
ip_tunnel_add(itn, netdev_priv(itn->fb_tunnel_dev));
}
rtnl_unlock();
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v2] ip_tunnel: Initialize the fallback device properly
2014-05-19 9:36 [PATCH net v2] ip_tunnel: Initialize the fallback device properly Steffen Klassert
@ 2014-05-21 6:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-21 6:09 UTC (permalink / raw)
To: steffen.klassert; +Cc: eric.dumazet, pshelar, netdev
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Mon, 19 May 2014 11:36:56 +0200
> We need to initialize the fallback device to have a correct mtu
> set on this device. Otherwise the mtu is set to null and the device
> is unusable.
>
> Fixes: fd58156e456d ("IPIP: Use ip-tunneling code.")
> Cc: Pravin B Shelar <pshelar@nicira.com>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
> ---
>
> v2: Add a reference to the commit that added the bug.
> No code changes since v1.
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-21 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-19 9:36 [PATCH net v2] ip_tunnel: Initialize the fallback device properly Steffen Klassert
2014-05-21 6:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).