From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, dborkman@redhat.com, kelly@xilka.com
Subject: Re: [Patch net] net_sched: fix an oops in tcindex filter
Date: Wed, 21 May 2014 16:51:08 -0400 (EDT) [thread overview]
Message-ID: <20140521.165108.1433532620660314918.davem@davemloft.net> (raw)
In-Reply-To: <1400526949-1344-1-git-send-email-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 19 May 2014 12:15:49 -0700
> From: Cong Wang <xiyou.wangcong@gmail.com>
>
> Kelly reported the following crash:
...
> This is because we memcpy struct tcindex_filter_result which contains
> struct tcf_exts, obviously struct list_head can not be simply copied.
> This is a regression introduced by commit 33be627159913b094bb578
> (net_sched: act: use standard struct list_head).
>
> It's not very easy to fix it as the code is a mess:
...
> Fixes: commit 33be627159913b0 (net_sched: act: use standard struct list_head)
> Reported-by: Kelly Anderson <kelly@xilka.com>
> Tested-by: Kelly Anderson <kelly@xilka.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2014-05-21 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 19:15 [Patch net] net_sched: fix an oops in tcindex filter Cong Wang
2014-05-21 20:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521.165108.1433532620660314918.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=kelly@xilka.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).