From: David Miller <davem@davemloft.net>
To: julia.lawall@lip6.fr
Cc: sergei.shtylyov@cogentembedded.com,
inaky.perez-gonzalez@intel.com, kernel-janitors@vger.kernel.org,
linux-wimax@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/13 v2] wimax/i2400m: make return of 0 explicit
Date: Wed, 21 May 2014 17:19:37 -0400 (EDT) [thread overview]
Message-ID: <20140521.171937.898588239489051362.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1405200844010.2723@hadrien>
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Tue, 20 May 2014 08:44:49 +0800 (SGT)
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Delete unnecessary local variable whose value is always 0 and that hides
> the fact that the result is always 0.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows: (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Alternatively, is an error code wanted under the if?
>
> v2: remove the use of 0 as an argument in the call to d_fnend
Applied to net-next, thanks.
next prev parent reply other threads:[~2014-05-21 21:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 4:31 [PATCH 0/13] make return of 0 explicit Julia Lawall
2014-05-19 4:31 ` [PATCH 1/13] libertas: " Julia Lawall
2014-05-19 7:43 ` walter harms
2014-05-19 12:45 ` Sergei Shtylyov
2014-05-19 17:25 ` Dan Williams
2014-05-22 12:32 ` [PATCH] libertas: fix return value when processing invalid packet Dan Williams
2014-05-22 21:57 ` James Cameron
2014-05-20 0:30 ` [PATCH 1/13] libertas: make return of 0 explicit Julia Lawall
2014-05-20 0:36 ` Julia Lawall
2014-05-19 4:31 ` [PATCH 4/13] wimax/i2400m: " Julia Lawall
2014-05-19 7:47 ` walter harms
2014-05-19 11:30 ` Julia Lawall
2014-05-19 13:22 ` walter harms
2014-05-19 12:46 ` Sergei Shtylyov
2014-05-20 0:44 ` [PATCH 4/13 v2] " Julia Lawall
2014-05-21 21:19 ` David Miller [this message]
2014-05-19 4:31 ` [PATCH 6/13] [NETFILTER]: arp_tables: " Julia Lawall
2014-05-19 4:31 ` [PATCH 12/13] brcmsmac: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521.171937.898588239489051362.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=inaky.perez-gonzalez@intel.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).