From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: hkchu@google.com, netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [PATCH net v2] ipv6: gro: fix CHECKSUM_COMPLETE support
Date: Wed, 21 May 2014 17:20:16 -0400 (EDT) [thread overview]
Message-ID: <20140521.172016.831231990758100731.davem@davemloft.net> (raw)
In-Reply-To: <1400561794.5367.89.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 19 May 2014 21:56:34 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> When GRE support was added in linux-3.14, CHECKSUM_COMPLETE handling
> broke on GRE+IPv6 because we did not update/use the appropriate csum :
>
> GRO layer is supposed to use/update NAPI_GRO_CB(skb)->csum instead of
> skb->csum
>
> Tested using a GRE tunnel and IPv6 traffic. GRO aggregation now happens
> at the first level (ethernet device) instead of being done in gre
> tunnel. Native IPv6+TCP is still properly aggregated.
>
> Fixes: bf5a755f5e918 ("net-gre-gro: Add GRE support to the GRO stack")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jerry Chu <hkchu@google.com>
> ---
> v2: use nlen instead of sizeof(*iph) to support extension headers
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-05-21 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1400548164.5367.80.camel@edumazet-glaptop2.roam.corp.google.com>
2014-05-20 4:41 ` [PATCH net] ipv6: gro: fix CHECKSUM_COMPLETE support Eric Dumazet
2014-05-20 4:56 ` [PATCH net v2] " Eric Dumazet
2014-05-21 21:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521.172016.831231990758100731.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).