From: David Miller <davem@davemloft.net>
To: dcbw@redhat.com
Cc: kumaran.4353@gmail.com, stephen@networkplumber.org,
avi.kp.137@gmail.com, edumazet@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net: Set NOCARRIER bit of etherdev state at initialization
Date: Fri, 23 May 2014 14:15:51 -0400 (EDT) [thread overview]
Message-ID: <20140523.141551.1253983630587935706.davem@davemloft.net> (raw)
In-Reply-To: <1400866681.18322.27.camel@dcbw.local>
From: Dan Williams <dcbw@redhat.com>
Date: Fri, 23 May 2014 12:38:01 -0500
> The current "carrier on until told otherwise" model is intentional,
> because not all drivers support carrier detection, and thus we must
> assume the carrier is on until the driver tells us it is not on.
>
> Would this patch break that model?
Absolutely correct, this change is completely inappropriate.
next prev parent reply other threads:[~2014-05-23 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 17:01 [PATCH 1/1] net: Set NOCARRIER bit of etherdev state at initialization Balakumaran Kannan
2014-05-23 17:38 ` Dan Williams
2014-05-23 18:15 ` David Miller [this message]
2014-05-24 13:22 ` Balakumaran Kannan
2014-05-27 15:24 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523.141551.1253983630587935706.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avi.kp.137@gmail.com \
--cc=dcbw@redhat.com \
--cc=edumazet@google.com \
--cc=kumaran.4353@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).