From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, thomas.petazzoni@free-electrons.com,
sebastian.hesselbarth@gmail.com,
gregory.clement@free-electrons.com, alior@marvell.com,
tawfik@marvell.com, andrew@lunn.ch
Subject: Re: [PATCH v3 0/8] net: ethernet: marvell: Assorted fixes
Date: Fri, 23 May 2014 17:01:27 -0300 [thread overview]
Message-ID: <20140523200127.GA14290@arch.cereza> (raw)
In-Reply-To: <20140523.153616.2078296737930596480.davem@davemloft.net>
On 23 May 03:36 PM, David Miller wrote:
> From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Date: Thu, 22 May 2014 20:06:55 -0300
>
> > New round for this assorted fixes and clean-up series. There is more room for
> > clean-ups, and I'll start preparing more patches once these are accepted.
> >
> > This series consists of cleanups and minor improvements on mvneta, mv643xx_eth
> > and mvmdio drivers. None of the patches imply any functionality change, except
> > for the patch six "Change the number of default rx queues to one".
> >
> > This patch reduces the driver's allocated resources and makes the multiqueue
> > path in the poll function not get taken. The previous patchset contains more
> > details:
> >
> > http://permalink.gmane.org/gmane.linux.network/315015
> >
> > As usual, any feedback on this will be well received!
>
> Series applied to net-next, but some comments:
>
> 1) Never use web sites to reference informative material, instead put it
> all explicitly into the commit message in your posting.
>
> Web sites and archives come and go, the commit message is forever and
> readily available to someone studying your changes.
>
OK, I'll keep this in mind.
> 2) Just get rid of that MVNETA_RX_POLL_WEIGHT and simply use the
> generic default NAPI_POLL_WEIGHT which has the same value.
>
> Any local NAPI weight selection must be done for a good reason and
> be fully documented with performance metrics et al.
>
OK.
> 3) I know you inherited this, but the MTU change failure behavior is
> not so great. If the system is low on memory it could fail and losing
> an interface completely during an MTU change is extremely poor behavior.
>
> I would suggest holding onto the old allocated TXQ resources, and
> restoring them if the allocation of the new ones fail.
>
> That way the MTU change itself would fail, but the interface would
> remain up with the original MTU.
>
> Please make sure that you properly revert the MTU adjustment in
> this failure path.
>
Oh, I see. Thanks for the feedback, I'll take a look at this next week.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2014-05-23 20:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 23:06 [PATCH v3 0/8] net: ethernet: marvell: Assorted fixes Ezequiel Garcia
2014-05-22 23:06 ` [PATCH v3 1/8] net: mv643xx_eth: Simplify mv643xx_eth_adjust_link() Ezequiel Garcia
2014-05-22 23:06 ` [PATCH v3 2/8] net: mvneta: Clean-up mvneta_tx_frag_process() Ezequiel Garcia
2014-05-22 23:06 ` [PATCH v3 3/8] net: mvneta: Check tx queue setup error in mvneta_change_mtu() Ezequiel Garcia
2014-05-22 23:06 ` [PATCH v3 4/8] net: mvneta: Clean-up mvneta_init() Ezequiel Garcia
2014-05-22 23:07 ` [PATCH v3 5/8] net: mvneta: Use prepare/commit API to simplify MAC address setting Ezequiel Garcia
2014-05-22 23:07 ` [PATCH v3 6/8] net: mvneta: Change the number of default rx queues to one Ezequiel Garcia
2014-05-22 23:07 ` [PATCH v3 7/8] net: mvmdio: Use devm_* API to simplify the code Ezequiel Garcia
2014-05-22 23:07 ` [PATCH v3 8/8] net: mvneta: Remove unneeded 'weigth' field Ezequiel Garcia
2014-05-23 19:36 ` [PATCH v3 0/8] net: ethernet: marvell: Assorted fixes David Miller
2014-05-23 20:01 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523200127.GA14290@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox