From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ondrej Zary Subject: Re: [PATCH 5/9] tlan: Restart autonegotiation on link loss Date: Wed, 28 May 2014 08:39:00 +0200 Message-ID: <201405280839.00973.linux@rainbow-software.org> References: <1401226727-5508-1-git-send-email-linux@rainbow-software.org> <1401226727-5508-6-git-send-email-linux@rainbow-software.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Samuel Chessman , netdev , "linux-kernel@vger.kernel.org" To: Florian Fainelli Return-path: In-Reply-To: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wednesday 28 May 2014, Florian Fainelli wrote: > Hi, > > 2014-05-27 14:38 GMT-07:00 Ondrej Zary : > > When link is lost on a card which uses internal PHY for 10 Mbit speeds, > > restart autonegotiation to allow switching between 10 and 100 Mbps > > speeds. > > I think you should take a look at implementing libphy read/write stubs > for this driver, that would allow you not to open-code such things. Yes, that would be good. However, I don't want to do any major PHY-related changes to the driver because it supports cards with various PHY configurations and I don't have all the different hardware to test. > > Signed-off-by: Ondrej Zary > > --- > > drivers/net/ethernet/ti/tlan.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/net/ethernet/ti/tlan.c > > b/drivers/net/ethernet/ti/tlan.c index 31d4a96..1047b3f 100644 > > --- a/drivers/net/ethernet/ti/tlan.c > > +++ b/drivers/net/ethernet/ti/tlan.c > > @@ -2721,6 +2721,7 @@ static void tlan_phy_finish_auto_neg(struct > > net_device *dev) else if (!(mode & 0x0080) && (mode & 0x0040)) > > priv->tlan_full_duplex = true; > > > > + /* switch to internal PHY for 10 Mbps */ > > if ((!(mode & 0x0180)) && > > (priv->adapter->flags & TLAN_ADAPTER_USE_INTERN_10) && > > (priv->phy_num != 0)) { > > @@ -2788,6 +2789,19 @@ static void tlan_phy_monitor(unsigned long data) > > dev->name); > > tlan_dio_write8(dev->base_addr, TLAN_LED_REG, 0); > > netif_carrier_off(dev); > > + if (priv->adapter->flags & > > TLAN_ADAPTER_USE_INTERN_10) { + /* power > > down internal PHY */ > > + u16 data = MII_GC_PDOWN | MII_GC_LOOPBK > > + | MII_GC_ISOLATE; > > + tlan_mii_sync(dev->base_addr); > > + tlan_mii_write_reg(dev, priv->phy[0], > > + MII_GEN_CTL, data); > > + /* set to external PHY */ > > + priv->phy_num = 1; > > + /* restart autonegotiation */ > > + tlan_set_timer(dev, (4*HZ/10), > > TLAN_TIMER_PHY_PDOWN); + return; > > + } > > } > > } > > > > -- > > Ondrej Zary > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" > > in the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ -- Ondrej Zary