From: David Miller <davem@davemloft.net>
To: kumaran.4353@gmail.com
Cc: steve.glendinning@shawell.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] driver: net: smsc911x: set NOCARRIER flag in driver initialization
Date: Thu, 29 May 2014 15:28:09 -0700 (PDT) [thread overview]
Message-ID: <20140529.152809.871745461296745132.davem@davemloft.net> (raw)
In-Reply-To: <5380EAF6.1090402@gmail.com>
From: Balakumaran Kannan <kumaran.4353@gmail.com>
Date: Sun, 25 May 2014 00:24:46 +0530
> @@ -2525,6 +2525,8 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
>
> netdev_info(dev, "MAC Address: %pM\n", dev->dev_addr);
>
> + netif_carrier_off(dev);
> +
> return 0;
>
You should do this before the network device is registered.
next prev parent reply other threads:[~2014-05-29 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 18:54 [PATCH 1/1] driver: net: smsc911x: set NOCARRIER flag in driver initialization Balakumaran Kannan
2014-05-29 22:28 ` David Miller [this message]
2014-05-30 13:05 ` Balakumaran Kannan
2014-05-30 20:42 ` David Miller
2014-06-03 14:15 ` Balakumaran Kannan
2014-06-03 16:29 ` Florian Fainelli
2014-06-03 22:24 ` David Miller
2014-06-04 5:05 ` Balakumaran Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529.152809.871745461296745132.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kumaran.4353@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).