From: David Miller <davem@davemloft.net>
To: jhs@mojatatu.com
Cc: ben@decadent.org.uk, netdev@vger.kernel.org,
stephen@networkplumber.org, vyasevic@redhat.com,
john.r.fastabend@intel.com, sfeldma@cumulusnetworks.com
Subject: Re: [net-next PATCH v2 1/1] bring netlink interface to par with brctl show macs
Date: Thu, 29 May 2014 22:08:01 -0700 (PDT) [thread overview]
Message-ID: <20140529.220801.2111563710536999957.davem@davemloft.net> (raw)
In-Reply-To: <53831FDD.4020902@mojatatu.com>
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Mon, 26 May 2014 07:05:01 -0400
> On 05/25/14 22:35, Ben Hutchings wrote:
>> On Sun, 2014-05-25 at 09:15 -0400, Jamal Hadi Salim wrote:
>
>>> + if (dev == NULL) {
>>> + pr_info("PF_BRIDGE: RTM_GETNEIGH with unknown ifindex\n");
>>
>> You left another debug message here.
>>
>>> + return -ENODEV;
>>> }
>
>>> + pr_info("PF_BRIDGE: RTM_GETNEIGH %s no dumper\n",
>>> + dev->name);
>>
>> And here.
>
> Those two just adhere to the coding style used in the rest of the fdb
> code. I could remove them and send subsequent patches to remove
> equivalent debugs in the rest of the code. To me they seem useful
> although i have seen very strong views against them in the past.
I think we have to get rid of these, because they are essentially
user triggerable.
prev parent reply other threads:[~2014-05-30 5:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 13:15 [net-next PATCH v2 1/1] bring netlink interface to par with brctl show macs Jamal Hadi Salim
2014-05-26 2:35 ` Ben Hutchings
2014-05-26 11:05 ` Jamal Hadi Salim
2014-05-30 5:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529.220801.2111563710536999957.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).