Re: [patch net] team: fix mtu setting

[Jiri Pirko <jiri@resnulli.us>]

Thu, May 29, 2014 at 09:33:19PM CEST, fbl@redhat.com wrote:
>On Thu, May 29, 2014 at 08:46:17PM +0200, Jiri Pirko wrote:
>> Now it is not possible to set mtu to team device which has a port
>> enslaved to it. The reason is that when team_change_mtu() calls
>> dev_set_mtu() for port device, notificator for NETDEV_PRECHANGEMTU
>> event is called and team_device_event() returns NOTIFY_BAD forbidding
>> the change. So fix this by returning NOTIFY_DONE here in case team is
>> changing mtu in team_change_mtu().
>> 
>> Introduced-by: 3d249d4c "net: introduce ethernet teaming device"
>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>> ---
>
>Alright, so changing the team's mtu is now allowed but changing
>port's mtu isn't allowed.
>LGTM.
>
>Since there are some common code between the unwide and the
>successful code paths, I'd suggest to simply use:
>...
>	list_for_each_entry() {
>		err = 
>		if (err)
>			break
>	}
>
>	if (err) {
>		unwind
>	}
>	else
>		dev->mtu = new_mtu;
>
>	<common code>
>
>But I suspect that due to the long function name, any
>additional indentation there will cause the code to look
>less readable.

Yep, I was thinking about the same thing, decided not to go that way for
now.

>
>Acked-by: Flavio Leitner <fbl@redhat.com>
>


Thanks for review!