From: Jean Sacren <sakiwit@gmail.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ieee802154: use helper function to get rid of redundancy
Date: Sun, 1 Jun 2014 08:23:17 -0600 [thread overview]
Message-ID: <20140601142317.GA19754@mail.gmail.com> (raw)
In-Reply-To: <20140601072655.GA12277@omega>
From: Alexander Aring <alex.aring@gmail.com>
Date: Sun, 01 Jun 2014 09:26:57 +0200
Hi Alex,
Thank you very much for the feedback.
> the at86rf230 driver supports several at86rf2xx chips. You split the
> at86rf212_set_channel which is at86rf212 specific in two function which
> are named at86rf230_foo.
I didn't "split" at86rf212_set_channel() in two functions. I spliced
those two sections of code and made at86rf212_set_channel() far
succinct and easy to read.
> Sorry, but I think we should not do this. One reason is that the code is
> much easier to read when we have one channel_set callback for at86rf23x
> and at86rf212 chips.
If you use one channel_set callback as before the change, how would you
overcome the redundancy?
> Btw. I preparing a big cleanup for this driver which supports regmap and
> asychronous handling for rx/tx paths.
Thank you for letting me know. I'm sure I will learn a lot.
next prev parent reply other threads:[~2014-06-01 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 23:39 [PATCH net-next] ieee802154: use helper function to get rid of redundancy Jean Sacren
2014-06-01 7:26 ` Alexander Aring
2014-06-01 14:23 ` Jean Sacren [this message]
[not found] ` <20140601142317.GA19754-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-01 14:35 ` Alexander Aring
2014-06-01 15:35 ` Jean Sacren
2014-06-01 16:39 ` Alexander Aring
2014-06-01 17:49 ` Jean Sacren
2014-06-01 17:53 ` Jean Sacren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140601142317.GA19754@mail.gmail.com \
--to=sakiwit@gmail.com \
--cc=alex.aring@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).