From: David Miller <davem@davemloft.net>
To: crquan@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] genetlink: remove superfluous assignment
Date: Mon, 02 Jun 2014 10:36:37 -0700 (PDT) [thread overview]
Message-ID: <20140602.103637.1919050358452105820.davem@davemloft.net> (raw)
In-Reply-To: <1401697081-17093-1-git-send-email-crquan@gmail.com>
From: crquan@gmail.com
Date: Mon, 2 Jun 2014 01:18:01 -0700
> the local variable ops and n_ops were just read out from family,
> and not changed, hence no need to assign back.
>
> Validation functions should operate on const parameters and not
> change anything.
>
> Signed-off-by: Cheng Renquan <crquan@gmail.com>
Applied, thanks Cheng.
prev parent reply other threads:[~2014-06-02 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 6:54 [PATCH] genetlink: remove superfluous assignment Cheng Renquan
2014-06-02 5:11 ` David Miller
2014-06-02 8:18 ` crquan
2014-06-02 17:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602.103637.1919050358452105820.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=crquan@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).