From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: fix inet_getid() and ipv6_select_ident() bugs
Date: Mon, 02 Jun 2014 14:10:13 -0700 (PDT) [thread overview]
Message-ID: <20140602.141013.742158259109147373.davem@davemloft.net> (raw)
In-Reply-To: <1401378314.3645.44.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 29 May 2014 08:45:14 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> I noticed we were sending wrong IPv4 ID in TCP flows when MTU discovery
> is disabled.
> Note how GSO/TSO packets do not have monotonically incrementing ID.
>
> 06:37:41.575531 IP (id 14227, proto: TCP (6), length: 4396)
> 06:37:41.575534 IP (id 14272, proto: TCP (6), length: 65212)
> 06:37:41.575544 IP (id 14312, proto: TCP (6), length: 57972)
> 06:37:41.575678 IP (id 14317, proto: TCP (6), length: 7292)
> 06:37:41.575683 IP (id 14361, proto: TCP (6), length: 63764)
>
> It appears I introduced this bug in linux-3.1.
>
> inet_getid() must return the old value of peer->ip_id_count,
> not the new one.
>
> Lets revert this part, and remove the prevention of
> a null identification field in IPv6 Fragment Extension Header,
> which is dubious and not even done properly.
>
> Fixes: 87c48fa3b463 ("ipv6: make fragment identifications less predictable")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks for the heads up about the
merge conflict with net-next.
prev parent reply other threads:[~2014-06-02 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 15:45 [PATCH net] net: fix inet_getid() and ipv6_select_ident() bugs Eric Dumazet
2014-06-02 21:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602.141013.742158259109147373.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).