netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] ipheth: Add support for iPad 2 and iPad 3
@ 2014-05-30 10:17 Kristian Evensen
  2014-06-02 23:12 ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Kristian Evensen @ 2014-05-30 10:17 UTC (permalink / raw)
  To: netdev; +Cc: Kristian Evensen

From: Kristian Evensen <kristian.evensen@gmail.com>

Each iPad model has a different product id, this patch adds support for iPad 2
(pid 0x12a2) and iPad 3 (pid 0x12a6). Note that iPad 2 must be jailbroken and a
third-party app must be used for tethering to work. On iPad 3, tethering works
out of the box (assuming your ISP is nice).

Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com>
---
 drivers/net/usb/ipheth.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/usb/ipheth.c b/drivers/net/usb/ipheth.c
index 421934c..973275f 100644
--- a/drivers/net/usb/ipheth.c
+++ b/drivers/net/usb/ipheth.c
@@ -59,6 +59,8 @@
 #define USB_PRODUCT_IPHONE_3GS  0x1294
 #define USB_PRODUCT_IPHONE_4	0x1297
 #define USB_PRODUCT_IPAD 0x129a
+#define USB_PRODUCT_IPAD_2	0x12a2
+#define USB_PRODUCT_IPAD_3	0x12a6
 #define USB_PRODUCT_IPAD_MINI    0x12ab
 #define USB_PRODUCT_IPHONE_4_VZW 0x129c
 #define USB_PRODUCT_IPHONE_4S	0x12a0
@@ -107,6 +109,14 @@ static struct usb_device_id ipheth_table[] = {
 		IPHETH_USBINTF_CLASS, IPHETH_USBINTF_SUBCLASS,
 		IPHETH_USBINTF_PROTO) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(
+		USB_VENDOR_APPLE, USB_PRODUCT_IPAD_2,
+		IPHETH_USBINTF_CLASS, IPHETH_USBINTF_SUBCLASS,
+		IPHETH_USBINTF_PROTO) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(
+		USB_VENDOR_APPLE, USB_PRODUCT_IPAD_3,
+		IPHETH_USBINTF_CLASS, IPHETH_USBINTF_SUBCLASS,
+		IPHETH_USBINTF_PROTO) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(
 		USB_VENDOR_APPLE, USB_PRODUCT_IPAD_MINI,
 		IPHETH_USBINTF_CLASS, IPHETH_USBINTF_SUBCLASS,
 		IPHETH_USBINTF_PROTO) },
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] ipheth: Add support for iPad 2 and iPad 3
  2014-05-30 10:17 [PATCH net-next] ipheth: Add support for iPad 2 and iPad 3 Kristian Evensen
@ 2014-06-02 23:12 ` David Miller
  2014-06-03  5:47   ` Kristian Evensen
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-06-02 23:12 UTC (permalink / raw)
  To: kristian.evensen; +Cc: netdev

From: Kristian Evensen <kristian.evensen@gmail.com>
Date: Fri, 30 May 2014 12:17:00 +0200

> From: Kristian Evensen <kristian.evensen@gmail.com>
> 
> Each iPad model has a different product id, this patch adds support for iPad 2
> (pid 0x12a2) and iPad 3 (pid 0x12a6). Note that iPad 2 must be jailbroken and a
> third-party app must be used for tethering to work. On iPad 3, tethering works
> out of the box (assuming your ISP is nice).
> 
> Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com>

These are just device ID additions, so I applied this to 'net'.

Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] ipheth: Add support for iPad 2 and iPad 3
  2014-06-02 23:12 ` David Miller
@ 2014-06-03  5:47   ` Kristian Evensen
  2014-06-03 18:31     ` Pritesh Kothari (pritkoth)
  0 siblings, 1 reply; 5+ messages in thread
From: Kristian Evensen @ 2014-06-03  5:47 UTC (permalink / raw)
  To: David Miller; +Cc: Network Development

On Tue, Jun 3, 2014 at 1:12 AM, David Miller <davem@davemloft.net> wrote:
> These are just device ID additions, so I applied this to 'net'.

Thanks for letting me know.

Btw, if anyone could do me a favor, I would appreciate it very much. I
was told that the CDMA iPads have different PIDs than the GSM models,
but I have not been able to confirm this. If anyone has a CDMA iPad,
could you please check the PID and let me know?

-Kristian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] ipheth: Add support for iPad 2 and iPad 3
  2014-06-03  5:47   ` Kristian Evensen
@ 2014-06-03 18:31     ` Pritesh Kothari (pritkoth)
  2014-06-03 19:38       ` Kristian Evensen
  0 siblings, 1 reply; 5+ messages in thread
From: Pritesh Kothari (pritkoth) @ 2014-06-03 18:31 UTC (permalink / raw)
  To: Kristian Evensen; +Cc: David Miller, Network Development


On Jun 2, 2014, at 10:47 PM, Kristian Evensen <kristian.evensen@gmail.com> wrote:

> Btw, if anyone could do me a favor, I would appreciate it very much. I
> was told that the CDMA iPads have different PIDs than the GSM models,
> but I have not been able to confirm this. If anyone has a CDMA iPad,
> could you please check the PID and let me know?

http://www.linux-usb.org/usb.ids says this, if it helps.

	12a2  iPad 2 (3G; 64GB)
	12a3  iPad 2 (CDMA)
	12a4  iPad 3 (wifi)
	12a5  iPad 3 (CDMA)
	12a6  iPad 3 (3G, 16 GB)
	12a9  iPad 2
	12ab  iPad 4 (WiFi, 32GB)

Regards.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] ipheth: Add support for iPad 2 and iPad 3
  2014-06-03 18:31     ` Pritesh Kothari (pritkoth)
@ 2014-06-03 19:38       ` Kristian Evensen
  0 siblings, 0 replies; 5+ messages in thread
From: Kristian Evensen @ 2014-06-03 19:38 UTC (permalink / raw)
  To: Pritesh Kothari (pritkoth); +Cc: David Miller, Network Development

On Tue, Jun 3, 2014 at 8:31 PM, Pritesh Kothari (pritkoth)
<pritkoth@cisco.com> wrote:
> http://www.linux-usb.org/usb.ids says this, if it helps.
>
>         12a2  iPad 2 (3G; 64GB)
>         12a3  iPad 2 (CDMA)
>         12a4  iPad 3 (wifi)
>         12a5  iPad 3 (CDMA)
>         12a6  iPad 3 (3G, 16 GB)
>         12a9  iPad 2
>         12ab  iPad 4 (WiFi, 32GB)

Thank you very much for the reference. I will patch in support for the
missing devices as soon as I can confirm the devices support
tethering.

-Kristian

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-06-03 19:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-30 10:17 [PATCH net-next] ipheth: Add support for iPad 2 and iPad 3 Kristian Evensen
2014-06-02 23:12 ` David Miller
2014-06-03  5:47   ` Kristian Evensen
2014-06-03 18:31     ` Pritesh Kothari (pritkoth)
2014-06-03 19:38       ` Kristian Evensen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).