From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: netdev@vger.kernel.org, VenkatKumar.Duvvuru@Emulex.com
Subject: Re: Pull request: Fixes for new ethtool RSS commands
Date: Mon, 02 Jun 2014 23:07:42 -0700 (PDT) [thread overview]
Message-ID: <20140602.230742.1657606763843010424.davem@davemloft.net> (raw)
In-Reply-To: <1401760161.14007.179.camel@deadeye.wl.decadent.org.uk>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Tue, 03 Jun 2014 02:49:21 +0100
> This addresses several problems I previously identified with the new
> ETHTOOL_{G,S}RSSH commands:
>
> 1. Missing validation of reserved parameters
> 2. Vague documentation
> 3. Use of unnamed magic number
> 4. No consolidation with existing driver operations
>
> I don't currently have access to suitable network hardware, but have
> tested these changes with a dummy driver that can support various
> combinations of operations and sizes, together with (a) Debian's ethtool
> 3.13 (b) ethtool 3.14 with the submitted patch to use ETHTOOL_{G,S}RSSH
> and minor adjustment for fixes 1 and 3.
>
> v2: Update RSS operations in vmxnet3 too
Pulled, will push out once my build test completes ;-)
next prev parent reply other threads:[~2014-06-03 6:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 1:49 Pull request: Fixes for new ethtool RSS commands Ben Hutchings
2014-06-03 1:50 ` [PATCH net-next 1/8] ethtool: Return immediately on error in ethtool_copy_validate_indir() Ben Hutchings
2014-06-03 1:50 ` [PATCH net-next 2/8] ethtool: Name the 'no change' value for setting RSS hash key but not indir table Ben Hutchings
2014-06-03 1:50 ` [PATCH net-next 3/8] ethtool: Improve explanation of the two arrays following struct ethtool_rxfh Ben Hutchings
2014-06-03 1:50 ` [PATCH net-next 4/8] ethtool: Expand documentation of ethtool_ops::{get,set}_rxfh() Ben Hutchings
2014-06-03 1:51 ` [PATCH net-next 5/8] ethtool: Disallow ETHTOOL_SRSSH with both indir table and hash key unchanged Ben Hutchings
2014-06-03 1:51 ` [PATCH net-next 6/8] ethtool, be2net: constify array pointer parameters to ethtool_ops::set_rxfh Ben Hutchings
2014-06-03 1:51 ` [PATCH v2 net-next 7/8] ethtool: Replace ethtool_ops::{get,set}_rxfh_indir() with {get,set}_rxfh() Ben Hutchings
2014-06-03 1:51 ` [PATCH net-next 8/8] ethtool: Check that reserved fields of struct ethtool_rxfh are 0 Ben Hutchings
2014-06-03 6:07 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-02 0:57 Pull request: Fixes for new ethtool RSS commands Ben Hutchings
2014-06-02 1:11 ` Ben Hutchings
2014-06-03 0:13 ` David Miller
2014-06-03 0:23 ` David Miller
2014-06-03 1:42 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602.230742.1657606763843010424.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=VenkatKumar.Duvvuru@Emulex.com \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).