From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Michael Braun <michael-dev@fami-braun.de>
Cc: Ivo van Doorn <IvDoorn@gmail.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
netdev@vger.kernel.org, users@rt2x00.serialmonkey.com,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rt2800usb:fix efuse detection
Date: Mon, 2 Jun 2014 15:06:32 +0200 [thread overview]
Message-ID: <20140602130631.GA1632@redhat.com> (raw)
In-Reply-To: <538B79A3.1080104@cogentembedded.com>
On Sun, Jun 01, 2014 at 11:06:11PM +0400, Sergei Shtylyov wrote:
> >+ rt2x00usb_vendor_request(rt2x00dev, USB_DEVICE_MODE,
> >+ USB_VENDOR_REQUEST_IN, 0, 0x11, &fwMode,
> >+ sizeof(fwMode), REGISTER_TIMEOUT_FIRMWARE);
> >+
> >+ if ((fwMode & 0x00000003) == 2)
>
> Operating directly on '__le32'? That doesn't look right.
rt2x00usb_register_read() helper can be used to do conversion. I also
dislike using 0x11 number instead of register name and prefer kernel
like variable names (i.e. fw_mode instead of fwMode).
Thanks
Stanislaw
next prev parent reply other threads:[~2014-06-02 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 17:52 [PATCH 0/2] rt2800usb: Fix support for USB 057c:8501 Michael Braun
2014-06-01 17:52 ` [PATCH 1/2] rt2800usb:fix efuse detection Michael Braun
2014-06-01 19:06 ` Sergei Shtylyov
2014-06-02 13:06 ` Stanislaw Gruszka [this message]
2014-06-01 17:52 ` [PATCH 2/2] rt2800usb:fix hang during firmware load Michael Braun
2014-06-01 19:09 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602130631.GA1632@redhat.com \
--to=sgruszka@redhat.com \
--cc=IvDoorn@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=michael-dev@fami-braun.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).