* [PATCH v2] net: driver: smsc: set NOCARRIER flag in dev at driver initialization
@ 2014-06-03 16:43 Balakumaran Kannan
2014-06-04 1:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Balakumaran Kannan @ 2014-06-03 16:43 UTC (permalink / raw)
To: netdev, davem, steve.glendinning
As smsc driver supports carrier detection, it should unset NOCARRIER
flag only after carrier state determination. By default that flag
is off so driver should set it before starting auto-negotiation
Signed-off-by: Balakumaran <Balakumaran.Kannan@ap.sony.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index a0fc151..5e13fa5 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2477,6 +2477,8 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
goto out_disable_resources;
}
+ netif_carrier_off(dev);
+
retval = register_netdev(dev);
if (retval) {
SMSC_WARN(pdata, probe, "Error %i registering device", retval);
--
1.8.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: driver: smsc: set NOCARRIER flag in dev at driver initialization
2014-06-03 16:43 [PATCH v2] net: driver: smsc: set NOCARRIER flag in dev at driver initialization Balakumaran Kannan
@ 2014-06-04 1:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-06-04 1:21 UTC (permalink / raw)
To: kumaran.4353; +Cc: netdev, steve.glendinning
From: Balakumaran Kannan <kumaran.4353@gmail.com>
Date: Tue, 03 Jun 2014 22:13:48 +0530
> As smsc driver supports carrier detection, it should unset NOCARRIER
> flag only after carrier state determination. By default that flag
> is off so driver should set it before starting auto-negotiation
>
> Signed-off-by: Balakumaran <Balakumaran.Kannan@ap.sony.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-04 1:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-03 16:43 [PATCH v2] net: driver: smsc: set NOCARRIER flag in dev at driver initialization Balakumaran Kannan
2014-06-04 1:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).