Netdev List
 help / color / mirror / Atom feed
From: yamamoto@valinux.co.jp (YAMAMOTO Takashi)
To: horms@verge.net.au
Cc: eric.dumazet@gmail.com, dev@openvswitch.org,
	netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [ovs-dev] [PATCH v4 net-next] MPLS: Use mpls_features to activate software MPLS GSO segmentation
Date: Tue,  3 Jun 2014 13:46:11 +0900 (JST)	[thread overview]
Message-ID: <20140603044611.C2B0970BA7@kuma.localdomain> (raw)
In-Reply-To: Your message of "Tue, 3 Jun 2014 13:30:47 +0900" <20140603043047.GB22191@verge.net.au>

> diff --git a/net/core/dev.c b/net/core/dev.c
> index 0355ca5..7c063ac 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2498,13 +2498,42 @@ static int dev_gso_segment(struct sk_buff *skb, netdev_features_t features)
>  	return 0;
>  }
>  
> +/* If MPLS offload request, verify we are testing hardware MPLS features
> + * instead of standard features for the netdev.
> + */
> +#ifdef CONFIG_NET_MPLS_GSO
> +static netdev_features_t net_mpls_features(struct sk_buff *skb,
> +					   netdev_features_t features,
> +					   __be16 type)
> +{
> +	int tmp;

this variable seems no longer used.

> +
> +	if (unlikely(type == htons(ETH_P_MPLS_UC) ||
> +		     type == htons(ETH_P_MPLS_MC)))

why unlikely?

otherwise,
Acked-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>

YAMAMOTO Takashi

  reply	other threads:[~2014-06-03  4:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02  4:43 [PATCH v4 net-next] MPLS: Use mpls_features to activate software MPLS GSO segmentation Simon Horman
2014-06-02 16:21 ` Thomas Graf
2014-06-03  0:16   ` Simon Horman
     [not found]     ` <20140603001640.GA31821-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-06-03  0:45       ` Jesse Gross
2014-06-03  2:38         ` Simon Horman
     [not found]           ` <20140603023852.GA20728-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-06-03  3:42             ` Eric Dumazet
2014-06-03  4:30               ` Simon Horman
2014-06-03  4:46                 ` YAMAMOTO Takashi [this message]
     [not found]                   ` <20140603044611.C2B0970BA7-0CV7wKnmZOB82hYKe6nXyg@public.gmane.org>
2014-06-03  4:49                     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140603044611.C2B0970BA7@kuma.localdomain \
    --to=yamamoto@valinux.co.jp \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@verge.net.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox