netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Simon Horman <horms@verge.net.au>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, Jesse Gross <jesse@nicira.com>,
	YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
	dev@openvswitch.org
Subject: Re: [PATCH v5 net-next] MPLS: Use mpls_features to activate software MPLS GSO segmentation
Date: Wed, 4 Jun 2014 11:13:36 +0100	[thread overview]
Message-ID: <20140604101336.GE17695@casper.infradead.org> (raw)
In-Reply-To: <1401839597-8961-1-git-send-email-horms@verge.net.au>

On 06/04/14 at 08:53am, Simon Horman wrote:
> If an MPLS packet requires segmentation then use mpls_features
> to determine if the software implementation should be used.
> 
> As no driver advertises MPLS GSO segmentation this will always be
> the case.
> 
> I had not noticed that this was necessary before as software MPLS GSO
> segmentation was already being used in my test environment. I believe that
> the reason for that is the skbs in question always had fragments and the
> driver I used does not advertise NETIF_F_FRAGLIST (which seems to be the
> case for most drivers). Thus software segmentation was activated by
> skb_gso_ok().
> 
> This introduces the overhead of an extra call to skb_network_protocol()
> in the case where where CONFIG_NET_MPLS_GSO is set and
> skb->ip_summed == CHECKSUM_NONE.
> 
> Thanks to Jesse Gross for prompting me to investigate this.
> 
> Signed-off-by: Simon Horman <horms@verge.net.au>
> Acked-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>

LGTM

Acked-by: Thomas Graf <tgraf@suug.ch>

  reply	other threads:[~2014-06-04 10:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 23:53 [PATCH v5 net-next] MPLS: Use mpls_features to activate software MPLS GSO segmentation Simon Horman
2014-06-04 10:13 ` Thomas Graf [this message]
2014-06-05 22:05 ` David Miller
2014-06-06  7:16   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140604101336.GE17695@casper.infradead.org \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=horms@verge.net.au \
    --cc=jesse@nicira.com \
    --cc=netdev@vger.kernel.org \
    --cc=yamamoto@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).