From: David Miller <davem@davemloft.net>
To: festevam@gmail.com
Cc: claudiu.manoil@freescale.com, netdev@vger.kernel.org,
fabio.estevam@freescale.com
Subject: Re: [PATCH] gianfar: Call netif_carrier_off() prior to registration
Date: Thu, 05 Jun 2014 15:04:16 -0700 (PDT) [thread overview]
Message-ID: <20140605.150416.1615019571569772686.davem@davemloft.net> (raw)
In-Reply-To: <1401836138-13253-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Tue, 3 Jun 2014 19:55:38 -0300
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Quoting David Miller:
> "At the moment you call register_netdev() the device is visible, notifications
> are sent to userspace, and userland tools can try to bring the interface up
> and see the incorrect link state, before you do the netif_carrier_off().
>
> Said another way, between the register_netdev() and netif_carrier_off() call,
> userspace can see the device in an inconsistent state."
>
> So call netif_carrier_off() prior to register_netdev().
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, thank you.
prev parent reply other threads:[~2014-06-05 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 22:55 [PATCH] gianfar: Call netif_carrier_off() prior to registration Fabio Estevam
2014-06-03 23:04 ` Florian Fainelli
2014-06-04 2:05 ` David Miller
2014-06-04 2:42 ` Florian Fainelli
2014-06-04 2:51 ` Fabio Estevam
2014-06-05 22:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605.150416.1615019571569772686.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.manoil@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).