From: David Miller <davem@davemloft.net>
To: alexander.stein@systec-electronic.com
Cc: daniel.krueger@systec-electronic.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe
Date: Thu, 05 Jun 2014 15:19:29 -0700 (PDT) [thread overview]
Message-ID: <20140605.151929.853679355962389356.davem@davemloft.net> (raw)
In-Reply-To: <1401958387-8154-1-git-send-email-alexander.stein@systec-electronic.com>
From: Alexander Stein <alexander.stein@systec-electronic.com>
Date: Thu, 5 Jun 2014 10:53:02 +0200
> From: Daniel Krueger <daniel.krueger@systec-electronic.com>
>
> It is also neat to show the actual offending MAC address instead of just
> rejecting it
>
> Signed-off-by: Daniel Krueger <daniel.krueger@systec-electronic.com>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>
> Changes in v2:
> * Use just a single line
I agree with other's feedback in that this code is not legitimate.
It should generate a random MAC address via the standard interfaces we
have for doing so, rather than failing to bring up the interface.
Interface bringup failure should be the absolute last resort, and we
should recover and still bring the interface up whenever we can.
prev parent reply other threads:[~2014-06-05 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 8:53 [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe Alexander Stein
2014-06-05 8:53 ` [PATCH v2 2/6] pch_gbe: Add module parameter for RGMII/GMII PHY mode selection Alexander Stein
2014-06-05 18:15 ` Florian Fainelli
2014-06-05 8:53 ` [PATCH v2 3/6] pch_gbe: change order of PHY address discovering Alexander Stein
2014-06-05 8:53 ` [PATCH v2 4/6] pch_gbe: remove unnecessary PHY resets Alexander Stein
2014-06-05 8:53 ` [PATCH v2 5/6] pch_gbe: reset PHY before first configuration Alexander Stein
2014-06-05 8:53 ` [PATCH v2 6/6] pch_gbe: remove shutdown and restart of interface after PHY settings change Alexander Stein
2014-06-05 18:00 ` [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe Florian Fainelli
2014-06-05 22:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605.151929.853679355962389356.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.stein@systec-electronic.com \
--cc=daniel.krueger@systec-electronic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).