* [PATCH net-next] mac802154: llsec: add forgotten list_del_rcu in key removal
@ 2014-06-06 12:27 Phoebe Buckheister
2014-06-06 23:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Phoebe Buckheister @ 2014-06-06 12:27 UTC (permalink / raw)
To: netdev; +Cc: linux-zigbee-devel, davem, Phoebe Buckheister
During key removal, the key object is freed, but not taken out of the
llsec key list properly. Fix that.
Signed-off-by: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
---
net/mac802154/llsec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mac802154/llsec.c b/net/mac802154/llsec.c
index e4a2558..1456f73 100644
--- a/net/mac802154/llsec.c
+++ b/net/mac802154/llsec.c
@@ -285,6 +285,7 @@ int mac802154_llsec_key_del(struct mac802154_llsec *sec,
mkey = container_of(pos->key, struct mac802154_llsec_key, key);
if (llsec_key_id_equal(&pos->id, key)) {
+ list_del_rcu(&pos->list);
llsec_key_put(mkey);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] mac802154: llsec: add forgotten list_del_rcu in key removal
2014-06-06 12:27 [PATCH net-next] mac802154: llsec: add forgotten list_del_rcu in key removal Phoebe Buckheister
@ 2014-06-06 23:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-06-06 23:26 UTC (permalink / raw)
To: phoebe.buckheister; +Cc: netdev, linux-zigbee-devel
From: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Date: Fri, 6 Jun 2014 14:27:52 +0200
> During key removal, the key object is freed, but not taken out of the
> llsec key list properly. Fix that.
>
> Signed-off-by: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-06 23:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-06 12:27 [PATCH net-next] mac802154: llsec: add forgotten list_del_rcu in key removal Phoebe Buckheister
2014-06-06 23:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).