[PATCH] isdn: mISDN: dsp_cmx.c: Cleaning up a define that is no longer available

[PATCH] isdn: mISDN: dsp_cmx.c: Cleaning up a define that is no longer available

[Rickard Strandqvist]

Removes an ifdef that is no longer available,
and that would cause a compile error if it was activated.

This was partly found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/isdn/mISDN/dsp_cmx.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/isdn/mISDN/dsp_cmx.c b/drivers/isdn/mISDN/dsp_cmx.c
index a4f05c5..9e9bdc0 100644
--- a/drivers/isdn/mISDN/dsp_cmx.c
+++ b/drivers/isdn/mISDN/dsp_cmx.c
@@ -1511,9 +1511,6 @@ dsp_cmx_send_member(struct dsp *dsp, int len, s32 *c, int members)
 			dsp->tx_R = t;
 			goto send_packet;
 		}
-#ifdef DSP_NEVER_DEFINED
-	}
-#endif
 	/* PROCESS DATA (three or more members) */
 	/* -> if echo is NOT enabled */
 	if (!dsp->echo.software) {
-- 
1.7.10.4

Re: [PATCH] isdn: mISDN: dsp_cmx.c: Cleaning up a define that is no longer available

[David Miller]

From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Date: Sat,  7 Jun 2014 01:25:30 +0200

> Removes an ifdef that is no longer available,
> and that would cause a compile error if it was activated.
> 
> This was partly found using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

This indentation looks wrong, and if you scan up you'll see why.

A different set of CPP guards create the openning curly brace(s):

	/* PROCESS DATA (two members) */
#ifdef CMX_CONF_DEBUG
	if (0) {
#else
		if (members == 2) {
#endif

This is crazy, and deleting only the DSP_NEVER_DEFINED part makes it
even more confusing because less sophisticated code analysis tools and
editing mode will think that the braces are unbalanced now.

I'm not applying this, it makes things worse not better, sorry.