From: Thierry Reding <thierry.reding@gmail.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: davem@davemloft.net, arnd@arndb.de, f.fainelli@gmail.com,
sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com,
David.Laight@ACULAB.COM, eric.dumazet@gmail.com,
haifeng.yan@linaro.org, jchxue@gmail.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] net: hisilicon: add hix5hd2 mac driver
Date: Fri, 6 Jun 2014 10:19:18 +0200 [thread overview]
Message-ID: <20140606081917.GD31915@ulmo> (raw)
In-Reply-To: <1401774577-16683-3-git-send-email-zhangfei.gao@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Tue, Jun 03, 2014 at 01:49:37PM +0800, Zhangfei Gao wrote:
[...]
> diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
> new file mode 100644
> index 0000000..e942173
> --- /dev/null
> +++ b/drivers/net/ethernet/hisilicon/Kconfig
> @@ -0,0 +1,27 @@
> +#
> +# HISILICON device configuration
> +#
> +
> +config NET_VENDOR_HISILICON
> + bool "Hisilicon devices"
> + default y
Can this default please be dropped? It's annoying because it will cause
this driver to be built for *every* ARM kernel by default, whether or
not that hardware is available on a given board.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-06 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 5:49 [PATCH v4 0/2] add hix5hd2 mac driver Zhangfei Gao
2014-06-03 5:49 ` [PATCH v4 1/2] Documentation: add Device tree bindings for Hisilicon hix5hd2 ethernet Zhangfei Gao
[not found] ` <1401774577-16683-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-03 5:49 ` [PATCH v4 2/2] net: hisilicon: add hix5hd2 mac driver Zhangfei Gao
2014-06-06 8:19 ` Thierry Reding [this message]
2014-06-06 8:24 ` David Miller
2014-06-03 6:39 ` [PATCH v4 0/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606081917.GD31915@ulmo \
--to=thierry.reding@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=haifeng.yan@linaro.org \
--cc=jchxue@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).