From: David Miller <davem@davemloft.net>
To: ixaphire@qrator.net
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] ipip, sit: fix ipv4_{update_pmtu,redirect} calls
Date: Tue, 10 Jun 2014 23:36:24 -0700 (PDT) [thread overview]
Message-ID: <20140610.233624.23993271628864053.davem@davemloft.net> (raw)
In-Reply-To: <20140606231921.2ff39106ac54216fd9170fae@qrator.net>
From: Dmitry Popov <ixaphire@qrator.net>
Date: Fri, 6 Jun 2014 23:19:21 +0400
> ipv4_{update_pmtu,redirect} were called with tunnel's ifindex (t->dev is a
> tunnel netdevice). It caused wrong route lookup and failure of pmtu update or
> redirect. We should use the same ifindex that we use in ip_route_output_* in
> *tunnel_xmit code. It is t->parms.link .
>
> Signed-off-by: Dmitry Popov <ixaphire@qrator.net>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2014-06-11 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 19:19 [PATCH] ipip, sit: fix ipv4_{update_pmtu,redirect} calls Dmitry Popov
2014-06-07 0:45 ` Cong Wang
2014-06-07 15:54 ` Dmitry Popov
2014-06-07 17:36 ` Dmitry Popov
2014-06-11 6:36 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-06 18:51 Dmitry Popov
2014-06-06 19:17 ` Dmitry Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610.233624.23993271628864053.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ixaphire@qrator.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).