From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch iproute2 1/3] iproute2: arpd: use ll_addr_a2n and ll_addr_n2a Date: Tue, 10 Jun 2014 18:09:40 +0200 Message-ID: <20140610160940.GD2991@minipsycho.orion> References: <1400159422-11797-1-git-send-email-jiri@resnulli.us> <1400159422-11797-2-git-send-email-jiri@resnulli.us> <20140515084342.1aaae42a@nehalam.linuxnetplumber.net> <20140515165051.GA2939@minipsycho.orion> <20140516205816.180bf3ac@nehalam.linuxnetplumber.net> <20140517085031.GA3006@minipsycho.orion> <20140609124722.33295eb5@nehalam.linuxnetplumber.net> <20140610155025.GC2991@minipsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, mschmidt@redhat.com To: Stephen Hemminger Return-path: Received: from mail-wg0-f42.google.com ([74.125.82.42]:54212 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbaFJQJn (ORCPT ); Tue, 10 Jun 2014 12:09:43 -0400 Received: by mail-wg0-f42.google.com with SMTP id z12so4057866wgg.13 for ; Tue, 10 Jun 2014 09:09:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140610155025.GC2991@minipsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Jun 10, 2014 at 05:50:25PM CEST, jiri@resnulli.us wrote: >Mon, Jun 09, 2014 at 09:47:22PM CEST, stephen@networkplumber.org wrote: >>On Sat, 17 May 2014 10:50:31 +0200 >>Jiri Pirko wrote: >> >>> Sat, May 17, 2014 at 05:58:16AM CEST, stephen@networkplumber.org wrote: >>> >On Thu, 15 May 2014 18:50:51 +0200 >>> >Jiri Pirko wrote: >>> > >>> >> Thu, May 15, 2014 at 05:43:42PM CEST, stephen@networkplumber.org wrote: >>> >> >On Thu, 15 May 2014 15:10:20 +0200 >>> >> >Jiri Pirko wrote: >>> >> > >>> >> >> Signed-off-by: Jiri Pirko >>> >> >> --- >>> >> >> misc/arpd.c | 6 +++--- >>> >> >> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >> >> >>> >> > >>> >> >Why not use more standard ether_ntoa ? >>> >> >>> >> Because the rest of the code uses ll_addr_n2a. There is no user of >>> >> ether_ntoa in iproute2. >>> > >>> >arpd is more of a standalone program. >>> >>> I know but it is a part of the package (git tree). The other instances >>> use ll_addr_n2a. I'm ok with using ether_ntoa, I just wanted to follow >>> what is already there. >>> >>> I can change it and post v2 it you want. I can also change other instances >>> of usage ll_addr_n2a to ether_ntoa. >>> >>> >> >>This is fine, just went ahead and merged this version. > > >Stephen, looks like you missed the last (3/3) patch from this set. I >can't see it in the iproute2 git. Oh, you already applied that before. That confused me because "iproute2: ipa: show port id" actuall adds code which calls hexstring_n2a :) Anyway, all good now. Sorry for the fuzz. > >Thanks > >Jiri