netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: octavian.purdila@intel.com
Cc: netdev@vger.kernel.org, christoph.paasch@uclouvain.be
Subject: Re: [PATCH net-next] net: add skb allocation flags to __pskb_copy
Date: Wed, 11 Jun 2014 00:41:08 -0700 (PDT)	[thread overview]
Message-ID: <20140611.004108.1527243476443283864.davem@davemloft.net> (raw)
In-Reply-To: <1402179569-19394-1-git-send-email-octavian.purdila@intel.com>

From: Octavian Purdila <octavian.purdila@intel.com>
Date: Sun,  8 Jun 2014 01:19:29 +0300

> There are several instances where a __pskb_copy is immediately
> followed by an skb_clone. Add a new parameter to __pskb_copy to allow
> the skb to be allocated from the fclone cache and thus speed up
> subsequent skb_clone calls.
> 
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>

These SKB_ALLOC_* values are really internal, let's not use them explicitly
outside of skbuff.h and skbuff.c

Change this interface to instead take a boolean, which when true will
cause and fclone allocation.

Thank you.

  reply	other threads:[~2014-06-11  7:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-07 22:19 [PATCH net-next] net: add skb allocation flags to __pskb_copy Octavian Purdila
2014-06-11  7:41 ` David Miller [this message]
     [not found] <b75b291eb5364f13904268302d789357@UCL-MBX03.OASIS.UCLOUVAIN.BE>
2014-06-08 15:59 ` Christoph Paasch
2014-06-08 16:49   ` Octavian Purdila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140611.004108.1527243476443283864.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=christoph.paasch@uclouvain.be \
    --cc=netdev@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).