netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] qlcnic: remove duplicate QLC_83XX_GET_LSO_CAPABILITY define
@ 2014-06-09 14:55 Dan Carpenter
  2014-06-09 19:01 ` Sony Chacko
  2014-06-11 22:01 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-06-09 14:55 UTC (permalink / raw)
  To: Shahed Shaikh; +Cc: Dept-HSGLinuxNICDev, netdev, kernel-janitors

The QLC_83XX_GET_LSO_CAPABILITY define is cut and pasted twice so we can
delete the second instance.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
index 97784d0..2bf101a 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
@@ -418,7 +418,6 @@ enum qlcnic_83xx_states {
 #define QLC_83XX_GET_FUNC_MODE_FROM_NPAR_INFO(val)	(val & 0x80000000)
 #define QLC_83XX_GET_LRO_CAPABILITY(val)		(val & 0x20)
 #define QLC_83XX_GET_LSO_CAPABILITY(val)		(val & 0x40)
-#define QLC_83XX_GET_LSO_CAPABILITY(val)		(val & 0x40)
 #define QLC_83XX_GET_HW_LRO_CAPABILITY(val)		(val & 0x400)
 #define QLC_83XX_GET_VLAN_ALIGN_CAPABILITY(val)	(val & 0x4000)
 #define QLC_83XX_GET_FW_LRO_MSS_CAPABILITY(val)	(val & 0x20000)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [patch] qlcnic: remove duplicate QLC_83XX_GET_LSO_CAPABILITY define
  2014-06-09 14:55 [patch] qlcnic: remove duplicate QLC_83XX_GET_LSO_CAPABILITY define Dan Carpenter
@ 2014-06-09 19:01 ` Sony Chacko
  2014-06-11 22:01 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Sony Chacko @ 2014-06-09 19:01 UTC (permalink / raw)
  To: Dan Carpenter, Shahed Shaikh
  Cc: Dept-HSG Linux NIC Dev, kernel-janitors@vger.kernel.org, netdev

> -----Original Message-----
> From: dept_hsg_linux_nic_dev-bounces@qlclistserver.qlogic.com
> [mailto:dept_hsg_linux_nic_dev-bounces@qlclistserver.qlogic.com] On
> Behalf Of Dan Carpenter
> Sent: Monday, June 09, 2014 7:56 AM
> To: Shahed Shaikh
> Cc: Dept-HSG Linux NIC Dev; kernel-janitors@vger.kernel.org; netdev
> Subject: [patch] qlcnic: remove duplicate QLC_83XX_GET_LSO_CAPABILITY
> define
> 
> The QLC_83XX_GET_LSO_CAPABILITY define is cut and pasted twice so we
> can delete the second instance.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
> index 97784d0..2bf101a 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
> @@ -418,7 +418,6 @@ enum qlcnic_83xx_states {
>  #define QLC_83XX_GET_FUNC_MODE_FROM_NPAR_INFO(val)	(val &
> 0x80000000)
>  #define QLC_83XX_GET_LRO_CAPABILITY(val)		(val & 0x20)
>  #define QLC_83XX_GET_LSO_CAPABILITY(val)		(val & 0x40)
> -#define QLC_83XX_GET_LSO_CAPABILITY(val)		(val & 0x40)
>  #define QLC_83XX_GET_HW_LRO_CAPABILITY(val)		(val & 0x400)

Acked-by: Sony Chacko <sony.chacko@qlogic.com>

Thanks,
Sony

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] qlcnic: remove duplicate QLC_83XX_GET_LSO_CAPABILITY define
  2014-06-09 14:55 [patch] qlcnic: remove duplicate QLC_83XX_GET_LSO_CAPABILITY define Dan Carpenter
  2014-06-09 19:01 ` Sony Chacko
@ 2014-06-11 22:01 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-06-11 22:01 UTC (permalink / raw)
  To: dan.carpenter; +Cc: shahed.shaikh, Dept-HSGLinuxNICDev, netdev, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 9 Jun 2014 17:55:39 +0300

> The QLC_83XX_GET_LSO_CAPABILITY define is cut and pasted twice so we can
> delete the second instance.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-06-11 22:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-09 14:55 [patch] qlcnic: remove duplicate QLC_83XX_GET_LSO_CAPABILITY define Dan Carpenter
2014-06-09 19:01 ` Sony Chacko
2014-06-11 22:01 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).