From: David Miller <davem@davemloft.net>
To: octavian.purdila@intel.com
Cc: netdev@vger.kernel.org, christoph.paasch@uclouvain.be,
alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
mareklindner@neomailbox.ch, sw@simonwunderlich.de,
antonio@meshcoding.com, marcel@holtmann.org, gustavo@padovan.org,
johan.hedberg@gmail.com, arvid.brodin@alten.se, kaber@trash.net,
pablo@netfilter.org, kadlec@blackhole.kfki.hu,
lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
sameo@linux.intel.com, jon.maloy@ericsson.com,
allan.stephens@windriver.com, andrew.hendry@gmail.com,
edumazet@google.com
Subject: Re: [PATCH net-next v4] net: add __pskb_copy_fclone and pskb_copy_for_clone
Date: Wed, 11 Jun 2014 15:14:26 -0700 (PDT) [thread overview]
Message-ID: <20140611.151426.1918105360214405187.davem@davemloft.net> (raw)
In-Reply-To: <1402522887-10600-1-git-send-email-octavian.purdila@intel.com>
From: Octavian Purdila <octavian.purdila@intel.com>
Date: Thu, 12 Jun 2014 00:41:27 +0300
> @@ -2235,9 +2241,17 @@ static inline dma_addr_t skb_frag_dma_map(struct device *dev,
> static inline struct sk_buff *pskb_copy(struct sk_buff *skb,
> gfp_t gfp_mask)
> {
> - return __pskb_copy(skb, skb_headroom(skb), gfp_mask);
> + return __pskb_copy_fclone(skb, skb_headroom(skb), gfp_mask, false);
> }
This hunk is unnecessary, the whole point of keeping __pskb_copy()'s signature
the same is to avoid these kinds of edits.
Please get rid of this hunk and I'll apply this, thank you!
prev parent reply other threads:[~2014-06-11 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 21:41 [PATCH net-next v4] net: add __pskb_copy_fclone and pskb_copy_for_clone Octavian Purdila
2014-06-11 22:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611.151426.1918105360214405187.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=allan.stephens@windriver.com \
--cc=aloisio.almeida@openbossa.org \
--cc=andrew.hendry@gmail.com \
--cc=antonio@meshcoding.com \
--cc=arvid.brodin@alten.se \
--cc=christoph.paasch@uclouvain.be \
--cc=dbaryshkov@gmail.com \
--cc=edumazet@google.com \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=jon.maloy@ericsson.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=lauro.venancio@openbossa.org \
--cc=marcel@holtmann.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=pablo@netfilter.org \
--cc=sameo@linux.intel.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).