From: David Miller <davem@davemloft.net>
To: octavian.purdila@intel.com
Cc: netdev@vger.kernel.org, christoph.paasch@uclouvain.be,
alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
mareklindner@neomailbox.ch, sw@simonwunderlich.de,
antonio@meshcoding.com, marcel@holtmann.org, gustavo@padovan.org,
johan.hedberg@gmail.com, arvid.brodin@alten.se, kaber@trash.net,
pablo@netfilter.org, kadlec@blackhole.kfki.hu,
lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
sameo@linux.intel.com, jon.maloy@ericsson.com,
allan.stephens@windriver.com, andrew.hendry@gmail.com,
edumazet@google.com
Subject: Re: [PATCH net-next v5] net: add __pskb_copy_fclone and pskb_copy_for_clone
Date: Wed, 11 Jun 2014 15:38:23 -0700 (PDT) [thread overview]
Message-ID: <20140611.153823.1721612284882638761.davem@davemloft.net> (raw)
In-Reply-To: <1402526186-18619-1-git-send-email-octavian.purdila@intel.com>
From: Octavian Purdila <octavian.purdila@intel.com>
Date: Thu, 12 Jun 2014 01:36:26 +0300
> There are several instances where a pskb_copy or __pskb_copy is
> immediately followed by an skb_clone.
>
> Add a couple of new functions to allow the copy skb to be allocated
> from the fclone cache and thus speed up subsequent skb_clone calls.
...
> Reviewed-by: Christoph Paasch <christoph.paasch@uclouvain.be>
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
> ---
>
> Changes since v4:
> * Oops, as Dave noticed, there is no need to rewrite pskb_copy()
>
> Changes since v3:
> * As suggested by David and Dave add new functions to keep the
> existing signatures unchanged and avoid unnecessary changes
>
> Changes since v2:
> * As suggested by Dave, use a bool instead of directly exposing the
> internal allocation flags
>
> Changes since v1:
> * add new parameter to pskb_copy as well, as suggested by Christoph
Applied to net-next, thanks a lot.
prev parent reply other threads:[~2014-06-11 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 22:36 [PATCH net-next v5] net: add __pskb_copy_fclone and pskb_copy_for_clone Octavian Purdila
2014-06-11 22:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611.153823.1721612284882638761.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=allan.stephens@windriver.com \
--cc=aloisio.almeida@openbossa.org \
--cc=andrew.hendry@gmail.com \
--cc=antonio@meshcoding.com \
--cc=arvid.brodin@alten.se \
--cc=christoph.paasch@uclouvain.be \
--cc=dbaryshkov@gmail.com \
--cc=edumazet@google.com \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=jon.maloy@ericsson.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=lauro.venancio@openbossa.org \
--cc=marcel@holtmann.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=pablo@netfilter.org \
--cc=sameo@linux.intel.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).