From: David Miller <davem@davemloft.net>
To: ixaphire@qrator.net
Cc: steffen.klassert@secunet.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] ip_vti: fix sparse warnings for VTI_ISVTI
Date: Wed, 11 Jun 2014 15:41:02 -0700 (PDT) [thread overview]
Message-ID: <20140611.154102.358172856037880938.davem@davemloft.net> (raw)
In-Reply-To: <20140611150914.c3cb48bb8a1a760564f5db6e@qrator.net>
From: Dmitry Popov <ixaphire@qrator.net>
Date: Wed, 11 Jun 2014 15:09:14 +0400
> This patch fixes the following sparse warnings:
>
> net/ipv4/ip_tunnel.c:245:53: warning: restricted __be16 degrades to integer
> net/ipv4/ip_vti.c:321:19: warning: incorrect type in assignment (different base types)
> net/ipv4/ip_vti.c:321:19: expected restricted __be16 [addressable] [assigned] [usertype] i_flags
> net/ipv4/ip_vti.c:321:19: got int
> net/ipv4/ip_vti.c:447:24: warning: incorrect type in assignment (different base types)
> net/ipv4/ip_vti.c:447:24: expected restricted __be16 [usertype] i_flags
> net/ipv4/ip_vti.c:447:24: got int
>
> Since VTI_ISVTI is always used with ip_tunnel_parm->i_flags (which is __be16),
> we can __force cast VTI_ISVTI to __be16 in header file.
>
> Signed-off-by: Dmitry Popov <ixaphire@qrator.net>
Applied.
prev parent reply other threads:[~2014-06-11 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 11:09 [PATCH] ip_vti: fix sparse warnings for VTI_ISVTI Dmitry Popov
2014-06-11 12:02 ` Dmitry Popov
2014-06-11 15:40 ` Stephen Hemminger
2014-06-11 22:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611.154102.358172856037880938.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ixaphire@qrator.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).