* [PATCH] net/fsl: Make xgmac_mdio read error message useful
@ 2014-06-11 18:41 Shruti Kanetkar
2014-06-11 22:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Shruti Kanetkar @ 2014-06-11 18:41 UTC (permalink / raw)
To: davem; +Cc: netdev, Shruti Kanetkar
Print the device address, the register number and the PHY ID for
which the MDIO read operation failed
Signed-off-by: Shruti Kanetkar <Shruti@Freescale.com>
---
drivers/net/ethernet/freescale/xgmac_mdio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index d449fcb..0c9d55c 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -162,7 +162,9 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum)
/* Return all Fs if nothing was there */
if (in_be32(®s->mdio_stat) & MDIO_STAT_RD_ER) {
- dev_err(&bus->dev, "MDIO read error\n");
+ dev_err(&bus->dev,
+ "Error while reading PHY%d reg at %d.%d\n",
+ phy_id, dev_addr, regnum);
return 0xffff;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/fsl: Make xgmac_mdio read error message useful
2014-06-11 18:41 [PATCH] net/fsl: Make xgmac_mdio read error message useful Shruti Kanetkar
@ 2014-06-11 22:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-06-11 22:59 UTC (permalink / raw)
To: Shruti; +Cc: netdev
From: Shruti Kanetkar <Shruti@Freescale.com>
Date: Wed, 11 Jun 2014 13:41:40 -0500
> Print the device address, the register number and the PHY ID for
> which the MDIO read operation failed
>
> Signed-off-by: Shruti Kanetkar <Shruti@Freescale.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-11 22:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-11 18:41 [PATCH] net/fsl: Make xgmac_mdio read error message useful Shruti Kanetkar
2014-06-11 22:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).