netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Florian Westphal <fw@strlen.de>, Jiri Slaby <jslaby@suse.cz>,
	stable@vger.kernel.org, ML netdev <netdev@vger.kernel.org>
Subject: Re: Linux 3.4.92 breaks forwarding with netfilter enabled
Date: Thu, 12 Jun 2014 10:54:27 -0700	[thread overview]
Message-ID: <20140612175427.GB30060@kroah.com> (raw)
In-Reply-To: <20140612172516.GA2556@bender.morinfr.org>

On Thu, Jun 12, 2014 at 07:25:16PM +0200, Guillaume Morin wrote:
> On 11 Jun 10:10, Florian Westphal wrote:
> >
> > Jiri Slaby <jslaby@suse.cz> wrote:
> > > > Gergely, please either revert
> > > > 
> > > > commit bd91cb56f951a7b0da8c3098ea9cd56854ece66c
> > > > Author: Florian Westphal <fw@strlen.de>
> > > > net: ipv4: ip_forward: fix inverted local_df test
> > > > [ Upstream commit ca6c5d4ad216d5942ae544bbf02503041bd802aa ]
> > > > 
> > > > Or, alternatively, also apply upstream commit 895162b1101b3ea5db08ca6822ae9672717efec0
> > > > Author: Florian Westphal <fw@strlen.de>
> > > > Date:   Fri May 2 15:32:16 2014 +0200
> > > > netfilter: ipv4: defrag: set local_df flag on defragmented skb
> > > > 
> > > > on top of your 3.4.92 kernel.
> > > > 
> > > > (The latter might be a better option since it will also fix the
> > > >  long-standing issue where netfilter sends bogus frag-needed message
> > > >  under very rare circumstances).
> > > 
> > > I believe, the same holds for 3.12, right? (I have just applied "defrag:
> > > set local_df flag on defragmented skb".)
> > 
> > Yes, its true for all -stable kernels (except new 3.15).
> > 
> > Thanks for taking care of this.
> 
> Greg, could you apply this one to 3.4,3.10,3.14 as well please?

I just did that :)

thanks,

greg k-h

      reply	other threads:[~2014-06-12 17:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140610220325.GG1970@breakpoint.cc>
2014-06-11  7:07 ` Linux 3.4.92 breaks forwarding with netfilter enabled Jiri Slaby
2014-06-11  8:10   ` Florian Westphal
2014-06-12 17:25     ` Guillaume Morin
2014-06-12 17:54       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140612175427.GB30060@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fw@strlen.de \
    --cc=jslaby@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).