From: David Miller <davem@davemloft.net>
To: bvanassche@acm.org
Cc: vyasevic@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Silence a W=1 compiler warning
Date: Fri, 13 Jun 2014 13:28:29 -0700 (PDT) [thread overview]
Message-ID: <20140613.132829.1371591602611461717.davem@davemloft.net> (raw)
In-Reply-To: <539B06E1.4050005@acm.org>
From: Bart Van Assche <bvanassche@acm.org>
Date: Fri, 13 Jun 2014 16:12:49 +0200
> Avoid that the following compiler warning is reported when building
> with W=1:
>
> include/linux/netdevice.h: In function 'netif_addr_lock_nested':
> include/linux/netdevice.h:2865:6: warning: variable 'subclass' set but not used [-Wunused-but-set-variable]
> int subclass = SINGLE_DEPTH_NESTING;
> ^
>
> This patch does not change any functionality.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
This has already been discussed.
The spin_lock_nested() with your configuration should be adjusted to
mark the argument as used.
There is nothing wrong with this code, it should not warn, it's
simply the spin locking macros that need to be fixed.
I'm not applying this patch, sorry.
prev parent reply other threads:[~2014-06-13 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 14:12 [PATCH] net: Silence a W=1 compiler warning Bart Van Assche
2014-06-13 20:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613.132829.1371591602611461717.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bvanassche@acm.org \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).