From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
pshelar@nicira.com, cwang@twopensource.com
Subject: Re: [Patch net] vxlan: use dev->needed_headroom instead of dev->hard_header_len
Date: Fri, 13 Jun 2014 15:29:26 -0700 (PDT) [thread overview]
Message-ID: <20140613.152926.1695048625021986920.davem@davemloft.net> (raw)
In-Reply-To: <1402599190-24350-1-git-send-email-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Thu, 12 Jun 2014 11:53:10 -0700
> From: Cong Wang <cwang@twopensource.com>
>
> When we mirror packets from a vxlan tunnel to other device,
> the mirror device should see the same packets (that is, without
> outer header). Because vxlan tunnel sets dev->hard_header_len,
> tcf_mirred() resets mac header back to outer mac, the mirror device
> actually sees packets with outer headers
>
> Vxlan tunnel should set dev->needed_headroom instead of
> dev->hard_header_len, like what other ip tunnels do. This fixes
> the above problem.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: stephen hemminger <stephen@networkplumber.org>
> Cc: Pravin B Shelar <pshelar@nicira.com>
> Signed-off-by: Cong Wang <cwang@twopensource.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
This looks good, and as you say consistent with how other IP tunnel
types are handled.
Applied, and queued up for -stable, thanks.
prev parent reply other threads:[~2014-06-13 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 18:53 [Patch net] vxlan: use dev->needed_headroom instead of dev->hard_header_len Cong Wang
2014-06-13 22:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613.152926.1695048625021986920.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).