* hyperv: fix apparent cut-n-paste error in send path teardown
@ 2014-06-16 20:59 Dave Jones
2014-06-17 4:36 ` David Miller
2014-06-17 10:13 ` KY Srinivasan
0 siblings, 2 replies; 3+ messages in thread
From: Dave Jones @ 2014-06-16 20:59 UTC (permalink / raw)
To: netdev; +Cc: kys
c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
some teardown code that looks like it was copied from the recieve path
above, but missed a variable name replacement.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index c041f63a6d30..4ed38eaecea8 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -189,7 +189,7 @@ static int netvsc_destroy_buf(struct netvsc_device *net_device)
"unable to teardown send buffer's gpadl\n");
return ret;
}
- net_device->recv_buf_gpadl_handle = 0;
+ net_device->send_buf_gpadl_handle = 0;
}
if (net_device->send_buf) {
/* Free up the receive buffer */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: hyperv: fix apparent cut-n-paste error in send path teardown
2014-06-16 20:59 hyperv: fix apparent cut-n-paste error in send path teardown Dave Jones
@ 2014-06-17 4:36 ` David Miller
2014-06-17 10:13 ` KY Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-06-17 4:36 UTC (permalink / raw)
To: davej; +Cc: netdev, kys
From: Dave Jones <davej@redhat.com>
Date: Mon, 16 Jun 2014 16:59:02 -0400
> c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
> some teardown code that looks like it was copied from the recieve path
> above, but missed a variable name replacement.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
Good catch, applied, thanks Dave.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: hyperv: fix apparent cut-n-paste error in send path teardown
2014-06-16 20:59 hyperv: fix apparent cut-n-paste error in send path teardown Dave Jones
2014-06-17 4:36 ` David Miller
@ 2014-06-17 10:13 ` KY Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: KY Srinivasan @ 2014-06-17 10:13 UTC (permalink / raw)
To: Dave Jones, netdev@vger.kernel.org
> -----Original Message-----
> From: Dave Jones [mailto:davej@redhat.com]
> Sent: Monday, June 16, 2014 1:59 PM
> To: netdev@vger.kernel.org
> Cc: KY Srinivasan
> Subject: hyperv: fix apparent cut-n-paste error in send path teardown
>
> c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
> some teardown code that looks like it was copied from the recieve path
> above, but missed a variable name replacement.
Thank you.
K. Y
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index
> c041f63a6d30..4ed38eaecea8 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -189,7 +189,7 @@ static int netvsc_destroy_buf(struct netvsc_device
> *net_device)
> "unable to teardown send buffer's
> gpadl\n");
> return ret;
> }
> - net_device->recv_buf_gpadl_handle = 0;
> + net_device->send_buf_gpadl_handle = 0;
> }
> if (net_device->send_buf) {
> /* Free up the receive buffer */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-17 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 20:59 hyperv: fix apparent cut-n-paste error in send path teardown Dave Jones
2014-06-17 4:36 ` David Miller
2014-06-17 10:13 ` KY Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).