From: David Miller <davem@davemloft.net>
To: himangi774@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
julia.lawall@lip6.fr
Subject: Re: [PATCH v2] net/nxp/lpc_eth: use devm_ functions
Date: Tue, 17 Jun 2014 15:31:14 -0700 (PDT) [thread overview]
Message-ID: <20140617.153114.745988923921147057.davem@davemloft.net> (raw)
In-Reply-To: <20140613180356.GA8582@himangi-Dell>
From: Himangi Saraogi <himangi774@gmail.com>
Date: Fri, 13 Jun 2014 23:33:56 +0530
> The various devm_ functions allocate memory that is released when a
> driver detaches. This patch uses dmam_alloc_coherent, devm_ioremap
> devm_clk_get etc. for data that is allocated in the probe function of
> platform device and is only freed in the remove function. The
> corresponding free functions are removed and many labels are done
> away with.
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> v2: undo use of devm_request_irq
> Not compile tested
This doesn't apply cleanly to any of my trees.
prev parent reply other threads:[~2014-06-17 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 18:03 [PATCH v2] net/nxp/lpc_eth: use devm_ functions Himangi Saraogi
2014-06-17 22:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617.153114.745988923921147057.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).