From: David Miller <davem@davemloft.net>
To: panweiping3@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: delete duplicate dev_set_rx_mode() call
Date: Tue, 17 Jun 2014 15:31:45 -0700 (PDT) [thread overview]
Message-ID: <20140617.153145.1029007671961636897.davem@davemloft.net> (raw)
In-Reply-To: <3b4f2d21523f2a03b21d4dc1350327752c634771.1402926490.git.panweiping3@gmail.com>
From: Weiping Pan <panweiping3@gmail.com>
Date: Mon, 16 Jun 2014 21:57:22 +0800
> In __dev_open(), it already calls dev_set_rx_mode().
> and dev_set_rx_mode() has no effect for a net device which does not have
> IFF_UP flag set.
>
> So the call of dev_set_rx_mode() is duplicate in __dev_change_flags().
>
> Signed-off-by: Weiping Pan <panweiping3@gmail.com>
Applied.
next prev parent reply other threads:[~2014-06-17 22:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 13:57 [PATCH net V2 0/2] net: delete duplicate dev_set_rx_mode() call Weiping Pan
2014-06-16 13:57 ` [PATCH net 1/2] " Weiping Pan
2014-06-17 22:31 ` David Miller [this message]
2014-06-16 13:57 ` [PATCH net 2/2] net: make some functions return void Weiping Pan
2014-06-16 16:16 ` Bjørn Mork
2014-06-17 22:32 ` David Miller
2014-06-16 17:14 ` [PATCH net V2 0/2] net: delete duplicate dev_set_rx_mode() call Cong Wang
-- strict thread matches above, loose matches on Subject: below --
2014-06-15 10:05 [PATCH net " Weiping Pan
2014-06-15 10:05 ` [PATCH net 1/2] " Weiping Pan
2014-06-16 3:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617.153145.1029007671961636897.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=panweiping3@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).