netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: b38611@freescale.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: fec: remove HW IP header checksum for IPV6 frame
Date: Wed, 18 Jun 2014 00:21:51 +0100	[thread overview]
Message-ID: <20140617232151.GO23430@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140617.153407.622542669190595342.davem@davemloft.net>

On Tue, Jun 17, 2014 at 03:34:07PM -0700, David Miller wrote:
> From: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Date: Tue, 17 Jun 2014 17:31:21 +0100
> > As I suspected, just applying the above two hunks fixes the problem
> > I was seeing.
> 
> Someone please respin the patch so that it's just these two hunks and that
> the commit message accurately describes the real situation.

I'm hoping for a reply from Freescale before I give an explicit tested-by
against this.  It would be nice to have some explicit confirmation that
they would be happy with a reduced patch.  It may be that the hardware
really does need the IP header checksum bit cleared for non-IPv4
packets.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

  reply	other threads:[~2014-06-17 23:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17  8:31 [PATCH] net: fec: remove HW IP header checksum for IPV6 frame Fugang Duan
2014-06-17 10:20 ` Russell King - ARM Linux
2014-06-17 16:31 ` Russell King - ARM Linux
2014-06-17 22:34   ` David Miller
2014-06-17 23:21     ` Russell King - ARM Linux [this message]
2014-06-18  1:40       ` fugang.duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140617232151.GO23430@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=b38611@freescale.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).